Reorder all function definitions before use in resize.js (fixes Codacy issues)#7095
Reorder all function definitions before use in resize.js (fixes Codacy issues)#7095stweil wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…y issues) Move every function declaration before the first call sites to eliminate Codacy 'defined before used' warnings for: resizeMap, toggleCollapseButtons, resizeSecondAndThird, handleMouseDown, resizeFirstAndSecond, resizeFirstAndThird, resizeVerticalFirstColumn, resizeVerticalSecondColumn, getElements, setSizes, setSectionHeightFirstColumn, setSectionHeightSecondColumn, toggleResizers, toggleCollapseButtons, toggleSecondColumn, updateMetadataEditorView. Assisted-by: qwen3.6-36b (Alibaba) Signed-off-by: Stefan Weil <sw@weilnetz.de>
|
Codacy reports 12 solved issues for this PR. |
|
@stweil Did you copy/paste these functions yourself or did you rely on Qwen to re-generate them 1:1 in a different place? I wouldn't really want to check whether there might be a one-character copy/paste mistake made by Qwen somewhere. |
|
Qwen claimed to have fixed all issues, but had only moved two functions (both correct). I fixed the rest manually by cut+paste operations. |
|
@thomaslow, here is a manual check: |
| secondSectionFirstColumn.height(sectionWrapperPosFirstColumn + sectionWrapperHeightFirstColumn - e.pageY - SEPARATOR_HEIGHT - HEADING_HEIGHT); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Here I added an empty line. Therefore the new file has one more line than the old one.
|
@stweil Thank you for clarifying. Nice idea sorting both files to check whether they are identical (apart from the order). |
thomaslow
left a comment
thomaslow
left a comment
There was a problem hiding this comment.
Resizing in the metadata editor works the same as before.
2 participants
Move every function declaration before the first call sites to eliminate Codacy 'defined before used' warnings for:
resizeMap, toggleCollapseButtons, resizeSecondAndThird,
handleMouseDown, resizeFirstAndSecond, resizeFirstAndThird,
resizeVerticalFirstColumn, resizeVerticalSecondColumn, getElements,
setSizes, setSectionHeightFirstColumn, setSectionHeightSecondColumn,
toggleResizers, toggleCollapseButtons, toggleSecondColumn,
updateMetadataEditorView.
Assisted-by: qwen3.6-36b (Alibaba)