Add initial configuration for ESLint (fix Codacy issues)#7096
Conversation
Codacy uses ESLint. Tell it that certain variables like `PF` are defined. This avoids related issue reports about undefined variables. Signed-off-by: Stefan Weil <sw@weilnetz.de>
Up to standards ✅🟢 Issues
|
|
It looks like this PR has not the desired effect on Codacy. Therefore I marked it as draft now |
|
Related documentation: |
|
According to the Codacy documentation, configuration files are always read from the default branch. So the change here has no effect until it was merged into the main branch. I suggest to do this, then we will see whether it works. |
henning-gerhardt
left a comment
There was a problem hiding this comment.
I can not review this as
- I did not have access to nor I'm using Codacy
- I did not know how Codacy is set up for Kitodo.Production and so I don't know is this change is really working or did anything
- I'm not familiar with ESLint and did not find any documentation of all this used configuration parameters
- ESLint is using be default a different configuration file naming
https://app.codacy.com/gh/kitodo/kitodo-production/issues/current does not work for you?
The Codacy Static Code Analysis is part of the checks which run for each pull request here. |
Which one? Please compare this documention. |
Codacy uses ESLint. Tell it that certain variables like
PFare defined. This avoids related issue reports about undefined variables.