Skip to content

Add initial configuration for ESLint (fix Codacy issues)#7096

Open
stweil wants to merge 1 commit into
kitodo:mainfrom
stweil:eslint
Open

Add initial configuration for ESLint (fix Codacy issues)#7096
stweil wants to merge 1 commit into
kitodo:mainfrom
stweil:eslint

Conversation

@stweil

@stweil stweil commented Jun 24, 2026

Copy link
Copy Markdown
Member

Codacy uses ESLint. Tell it that certain variables like PF are defined. This avoids related issue reports about undefined variables.

Codacy uses ESLint. Tell it that certain variables like `PF` are defined.
This avoids related issue reports about undefined variables.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@stweil stweil marked this pull request as draft June 24, 2026 10:38
@stweil

stweil commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

It looks like this PR has not the desired effect on Codacy. Therefore I marked it as draft now

@stweil

stweil commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

@stweil stweil marked this pull request as ready for review June 24, 2026 21:12
@stweil

stweil commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

According to the Codacy documentation, configuration files are always read from the default branch. So the change here has no effect until it was merged into the main branch. I suggest to do this, then we will see whether it works.

@solth solth requested a review from henning-gerhardt June 24, 2026 21:24

@henning-gerhardt henning-gerhardt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not review this as

  • I did not have access to nor I'm using Codacy
  • I did not know how Codacy is set up for Kitodo.Production and so I don't know is this change is really working or did anything
  • I'm not familiar with ESLint and did not find any documentation of all this used configuration parameters
  • ESLint is using be default a different configuration file naming

@stweil

stweil commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

I did not have access to nor I'm using Codacy

https://app.codacy.com/gh/kitodo/kitodo-production/issues/current does not work for you?

I did not know how Codacy is set up for Kitodo.Production

The Codacy Static Code Analysis is part of the checks which run for each pull request here.

@stweil

stweil commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

ESLint is using be default a different configuration file naming

Which one? Please compare this documention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants