Repository navigation
feat(repositories): suggest popular repositories on repos page (#230) - #763
Conversation
…orio#230) - Add popular Helm repositories dataset - Add suggestion chips in AddRepositoryModal to auto-fill name and URL - Add Popular Suggestions sidebar section in RepositoriesList with quick add button - Enhance empty state in RepositoryViewer with popular repository cards - Add Cypress component test for preset suggestions
undera
left a comment
There was a problem hiding this comment.
Thanks for picking up #230. A few things need addressing:
1. Search params are lost when updated back to back. upsertSearchParams and removeSearchParam each build from the same search snapshot (hooks/useCustomSearchParams.ts), so only the last call in a row takes effect:
- Sidebar "+ Add" and empty-state "+ Add": only
add_repo=truesurvives, so the modal opens with empty fields. - Closing the modal: after
removeSearchParam("add_repo"), the two added removals overwrite it, soadd_repo=truestays in the URL and the modal no longer closes. This breaks the existing Cancel/close behavior.
The Cypress test covers only the chips inside the modal, which set form state directly, so it doesn't catch either case.
2. Scope. The same list appears in three places: modal chips, sidebar section, and empty-state grid. The modal chips alone cover the issue and need no URL-param plumbing, which also lets you drop the prevRepoName/prevRepoUrl sync. The new empty state also renders whenever repository === undefined, including the moment while repositories are loading, so a large grid would flash before the redirect to the first repo.
Please keep only the modal chips. If you'd rather keep the other entry points, set all params in a single setSearchParams call, for both opening and closing.
3. List contents. Bitnami's public catalog was cut back in 2025 and moved to OCI, so charts.bitnami.com/bitnami isn't a good first suggestion. ingress-nginx has been retired upstream. Please replace both with actively maintained repos.
…epo list - Focus popular suggestions exclusively on AddRepositoryModal chips without URL param plumbing - Remove prevRepoName/prevRepoUrl state sync logic - Revert sidebar and empty-state additions to keep scope minimal and avoid flash on load - Replace Bitnami and Ingress-Nginx with actively maintained Cilium and Traefik repos - Update Argo repo URL to https://argoproj.github.io/argo-helm - Update Cypress component tests for Jetstack and Traefik presets
|
Thanks for the thorough review and helpful feedback @undera ! I have addressed all three points in the latest commit:
|
Changes Proposed
Closes #230.
Suggests several popular Helm chart repositories on the Repositories page:
Bitnami,Jetstack,Ingress-Nginx,Prometheus-Community,Grafana,Argo,Komodor).AddRepositoryModalto auto-fill the repository Name and URL on click.RepositoriesListthat filters out already-installed repositories and provides a 1-click+ Addbutton.RepositoryViewerwhen no repositories are installed or selected to display quick-add cards.AddRepositoryModal.cy.tsxfor preset suggestions and auto-filling.Check List