Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: enforce restricted PSS for CI user namespace #3487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
test: enforce restricted PSS for CI user namespace #3487
Changes from all commits
c62cccd86c3b327893dbad3762d4eb452f09f0aed4fdd7b9308df5a9548da1e6dcf65e4d6d72066cffdb3de2525c09bd7b3bc4d1791392066e70923f7ce7705b6fef71b63367d1e104b53e2f5ee31ff6d8c4d0d4File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you upstream this or make sure to only patch the securitycontext, but not the image for example ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split to kubeflow/katib#2683; the intended delta is only
securityContext/injection config, not image changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the
securityContextis intended, but it cannot be expressed as a partial patch:katib-config.yamlis one opaque string inside thekatib-configConfigMap, so kustomize can only replace the whole file. The overlay is a temporary full copy until kubeflow/katib#2683, which adds the same suggestion and metrics-collector contexts to the default configuration upstream, is released and synchronized. At that point this overlay is deleted. The image tags in the copy are identical to the synchronized upstream ones (v0.19.0).Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.