config: add restricted PSS contexts for suggestions - #2683
Conversation
|
🎉 Welcome to the Kubeflow Katib repo! 🎉 Thanks for opening your first PR! We're excited to have you onboard 🚀 Next steps:
Feel free to ask questions in the comments. Thanks again for contributing! 🙏 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
2617764 to
8ab8afe
Compare
|
Two notes from testing this alongside the downstream restricted Pod Security Standards work in kubeflow/community-distribution#3487.
On the fixed The durable fix would be a numeric One thing I could not verify and that is worth a second look: whether all writable paths work under the selected identity for the |
|
/retest |
What this PR does / why we need it:
This PR makes the built-in Katib suggestion deployments compatible with Kubernetes restricted Pod Security Standards by using existing
runtime.suggestions[*].securityContextsupport in the install configs.It also enables
init.controller.injectSecurityContextso Katib metrics collector init containers get restricted-compatible security contexts. No API/schema fields or Trial template mutation are added.OpenShift install note:
katib-openshiftkeeps the restricted fields but omits a fixedrunAsUserso OpenShift SCC UID allocation can choose the namespace-assigned UID.Validation:
KUBEBUILDER_ASSETS="$(/home/danish/go/bin/setup-envtest use 1.34.0 -p path)" go test -count=1 ./pkg/util/v1beta1/katibconfig ./pkg/controller.v1beta1/suggestion/composerkustomize buildfor all six install overlays pluskatib-with-kubeflowgit diff --checkWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to kubeflow/community-distribution#3487
Checklist: