Skip to content

chore(spark): create ResourceDict type alias for resource specifications - #758

Open
Neha-Nimsatkar wants to merge 3 commits into
kubeflow:mainfrom
Neha-Nimsatkar:refactor/spark-resource-dict-alias
Open

chore(spark): create ResourceDict type alias for resource specifications#758
Neha-Nimsatkar wants to merge 3 commits into
kubeflow:mainfrom
Neha-Nimsatkar:refactor/spark-resource-dict-alias

Conversation

@Neha-Nimsatkar

Copy link
Copy Markdown

What this PR does / why we need it:
This PR introduces a centralized ResourceDict type alias (dict[str, str | int | float]) defined in kubeflow.spark.types.types and updates all Spark SDK module signatures (Driver, Executor, client methods, backend methods, and utility functions) to use it.

This eliminates repeated type definition boilerplate across the module and improves type safety for driver and executor resource specifications, addressing design feedback from PR #752.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
N/A (Follow-up refactor to PR #752)

Checklist:

  • Docs included if any changes are user facing

…ations

Signed-off-by: nehanimsatkar14 <nimsatkarneha2004@gmail.com>
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign electronic-waste for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

🎉 Welcome to the Kubeflow SDK! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards
  • Our team will review your PR soon! cc @kubeflow/kubeflow-sdk-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

@Neha-Nimsatkar Neha-Nimsatkar changed the title refactor(spark): create ResourceDict type alias for resource specifications refactor(spark): Create ResourceDict type alias for resource specifications Aug 12, 2026
@Neha-Nimsatkar Neha-Nimsatkar changed the title refactor(spark): Create ResourceDict type alias for resource specifications refactor(spark): create ResourceDict type alias Aug 12, 2026
@Neha-Nimsatkar Neha-Nimsatkar changed the title refactor(spark): create ResourceDict type alias refactor(spark): extract ResourceDict type alias for SDK resource specifications Aug 12, 2026
@Neha-Nimsatkar Neha-Nimsatkar changed the title refactor(spark): extract ResourceDict type alias for SDK resource specifications refactor(spark): extract resourcedict type alias for sdk resource specifications Aug 12, 2026
@Neha-Nimsatkar Neha-Nimsatkar changed the title refactor(spark): extract resourcedict type alias for sdk resource specifications chore(spark): create ResourceDict type alias for resource specifications Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants