chore(spark): create ResourceDict type alias for resource specifications - #758
Open
Neha-Nimsatkar wants to merge 3 commits into
Open
chore(spark): create ResourceDict type alias for resource specifications#758Neha-Nimsatkar wants to merge 3 commits into
Neha-Nimsatkar wants to merge 3 commits into
Conversation
…ations Signed-off-by: nehanimsatkar14 <nimsatkarneha2004@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
google-oss-prow
Bot
requested review from
Electronic-Waste,
kramaranya and
szaher
August 12, 2026 19:47
Contributor
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a centralized
ResourceDicttype alias (dict[str, str | int | float]) defined inkubeflow.spark.types.typesand updates all Spark SDK module signatures (Driver, Executor, client methods, backend methods, and utility functions) to use it.This eliminates repeated type definition boilerplate across the module and improves type safety for driver and executor resource specifications, addressing design feedback from PR #752.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):N/A (Follow-up refactor to PR #752)
Checklist: