fix: ModelRegistryClient ignored explicit URL ports - #763
Open
a-reda-ok wants to merge 1 commit into
Open
Conversation
…ot passed explicitly. Signed-off-by: Reda Boussaadi <redaredaboussaadi@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes
ModelRegistryClientport inference so URLs with an explicit port (for example,https://example.org:456orhttp://example.org:456) correctly use that port whenportis not passed as an argument.Previously, initialization only inferred port from scheme (
443for HTTPS,8080for HTTP), which silently ignored explicit URL ports and could route clients to the wrong endpoint. The fix parsesbase_urlwithurlsplitand prefersparsed_url.portbefore falling back to scheme defaults. This preserves existing behavior for URLs without explicit ports while making documented explicit-port behavior actually work.Regression coverage was updated in
model_registry_client_test.pyso both explicit HTTP/HTTPS port cases now assertport=456, validating the corrected behavior.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: