Skip to content

fix(trainer): support S3 and DataCache initializers in TorchTune dataset args - #767

Open
Lu2077 wants to merge 1 commit into
kubeflow:mainfrom
Lu2077:fix-torchtune-dataset-args
Open

fix(trainer): support S3 and DataCache initializers in TorchTune dataset args#767
Lu2077 wants to merge 1 commit into
kubeflow:mainfrom
Lu2077:fix-torchtune-dataset-args

Conversation

@Lu2077

@Lu2077 Lu2077 commented Aug 20, 2026

Copy link
Copy Markdown

Hi! As discussed in issue #741, I opened this PR to fix the missing dataset arguments for S3DatasetInitializer and DataCacheInitializer inside get_args_using_torchtune_config. The function now should properly emits the dataset.data_dir arg instead skipping it. Thanks for the guidance!

…args

Signed-off-by: Lu2077 <diaz.lu18@gmail.com>
Copilot AI balanced review requested due to automatic review settings August 20, 2026 22:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign astefanutti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

🎉 Welcome to the Kubeflow SDK! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards
  • Our team will review your PR soon! cc @kubeflow/kubeflow-sdk-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

@Lu2077 Lu2077 changed the title fix(sdk): support S3 and DataCache initializers in TorchTune dataset args fix(trainer): support S3 and DataCache initializers in TorchTune dataset args Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants