Skip to content

fix(trainer): preserve local job status in list_jobs - #770

Open
SahilKumar75 wants to merge 1 commit into
kubeflow:mainfrom
SahilKumar75:fix/localprocess-list-job-status
Open

fix(trainer): preserve local job status in list_jobs#770
SahilKumar75 wants to merge 1 commit into
kubeflow:mainfrom
SahilKumar75:fix/localprocess-list-job-status

Conversation

@SahilKumar75

@SahilKumar75 SahilKumar75 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

LocalProcessBackend.list_jobs() currently omits the overall status when constructing each TrainJob. As a result, listed jobs report the default Unknown status even when they are complete, failed, running, or created.

This change calculates each job status using the same logic as get_job() and includes it in the returned TrainJob. It also adds a regression test confirming that a completed local job is listed with the Complete status.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):

Fixes #703

Checklist:

  • Docs are not needed because this corrects existing behavior without changing the public interface

Signed-off-by: Sahil Kumar Singh <60318530+SahilKumar75@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 23, 2026 04:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kramaranya for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SahilKumar75 SahilKumar75 changed the title Fix local job status in list_jobs fix(trainer): preserve local job status in list_jobs Aug 24, 2026
@SahilKumar75

Copy link
Copy Markdown
Contributor Author

The title has been corrected to the repository format. Could a Kubeflow approver please review this change and add LGTM if it is ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LocalProcessBackend.list_jobs() returns TrainJob objects with Unknown status instead of actual job status

2 participants