feat: add reusable verify-boilerplate composite action - #1071
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| @@ -0,0 +1,38 @@ | |||
| name: "Verify Boilerplate Copyright Headers" | |||
| description: >- | |||
| Runs kubeflow/testing's hack/boilerplate/boilerplate.py against the repo's | |||
There was a problem hiding this comment.
Please use a spell checker.
Repo -> repository
| inputs: | ||
| base-ref: | ||
| description: >- | ||
| Base ref to diff against for new-file detection. Defaults to the PR base |
| Runs kubeflow/testing's hack/boilerplate/boilerplate.py against the repo's | ||
| changed files so callers never need to vendor a divergent copy of the script. | ||
| inputs: | ||
| base-ref: |
| branch (github.base_ref). | ||
| required: false | ||
| default: ${{ github.base_ref }} | ||
| boilerplate-dir: |
|
Hi @TrueFurina for the issue, we have PR for it. #1070 Please check that, you can help us by reviewing it. |
|
Closing this in favor of #1070. |
|
/close |
|
@tariq-hasan: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary
Adds a reusable composite action (
.github/actions/verify-boilerplate) that wraps this repo'shack/boilerplate/boilerplate.py, so Kubeflow repos can call it directly instead of vendoring and maintaining a divergent copy of the script (which currently drifts and makes the "downloaded from kubeflow/testing @ " comment unverifiable).Requirements met
hack/boilerplate/boilerplate.py, script sourced from this repo — callers never vendor itbase-refinput defaulting togithub.base_ref(PR base branch), so only changed/new files drive new-file detectionboilerplate-dirinput for repos that keep custom templates (defaults to this repo's templates)actions/setup-python) so callers don't each add a setup stepChanges
.github/actions/verify-boilerplate/action.ymlVerification
runs.using: composite)github.base_refandgithub.action_pathcorrectly