fixup the api-approved annotation#174
Conversation
The previous pr in our api-approved.kubernetes.io annotation did not include a review from the members of the `sig-network-api-approvers` group. This PR is the original API implementation PR that was reviewed/approved by Tim Hockin, the core of the API hasn't really chaged since then. For future releases with major API changes we will ensure that the API is properly reviewed. Signed-off-by: astoycos <astoycos@redhat.com>
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
approved
|
/hold Until Tim/Jordan look at this |
k8s-ci-robot
added
the
do-not-merge/hold
|
mechanically, this looks like what I'd expect... I'll defer to @thockin to ack that the API shape matches what was reviewed there
That sounds good, any ideas on how to ensure that isn't forgotten? |
|
@liggitt we've spoken with the chairs and will not cut an official release without an ACK from them 👍 |
astoycos
removed
the
do-not-merge/hold
|
@astoycos : Any updates on this one? I'd love a minor release since now nodes has merged and I plan on getting cidrs merged as well. If not I can continue using the commitID not a big deal. |
|
@tssurya If you could LGTM it I think we're good to go!! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astoycos, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 participants
The previous pr in our api-approved.kubernetes.io annotation did not include a review from the members of the
sig-network-api-approversgroup. This PR is the original API implementation PR that was reviewed/approved by Tim Hockin, the core of the API hasn't really chaged since then. For future releases with major API changes we will ensure that the API is properly reviewed.Please see #143 (comment) for more information on this
cc @thockin @liggitt