Remove O_DIRECT since we don't have aligned data - #5
Merged
Conversation
pobthebuilder
force-pushed
the
fix_odirect
branch
2 times, most recently
from
March 19, 2026 19:09
587ad10 to
033b220
Compare
pobthebuilder
force-pushed
the
fix_odirect
branch
from
March 19, 2026 19:58
033b220 to
c8d328f
Compare
kwertop
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs.constants.O_DIRECT requires the data to be at the same alignment at the filesystem which is complex to achieve. None of our data is aligned, so remove this flag.
Fixes #4