refactor: clean up bad code that clippy didn't find

[kxxt]

Summary by CodeRabbit

• Bug Fixes

  • Improved tracer startup validation by reporting clear errors when required configuration is missing.
  • Replaced runtime panics with graceful errors for invalid spawn tokens.
  • Improved shutdown handling when fatal-error notifications cannot be delivered.

• Tests

  • Added coverage for tracer configuration validation and spawn-token ownership.
  • Strengthened output, PTY, event, configuration, and exporter test assertions.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tracexec	Ready	Preview, Comment	Jul 15, 2026 3:32pm

[coderabbitai]

Walkthrough

The ptrace tracer now validates required configuration and returns errors for invalid spawn tokens or dropped fatal-error receivers. Tests add coverage for these paths and simplify several existing test setups, assertions, ownership, reads, and error construction.

Changes

Tracer robustness and test maintenance

Layer / File(s)	Summary
Fallible tracer construction and spawning crates/tracexec-backend-ptrace/src/ptrace/tracer.rs, crates/tracexec-backend-ptrace/src/ptrace/tracer/test.rs	Required builder fields and spawn-token ownership now produce errors instead of panics; fatal-error delivery ignores receiver-send failure, with tests covering missing configuration and mismatched tokens.
Test setup and assertion cleanup crates/tracexec-backend-ptrace/src/ptrace/tracer/inner.rs, crates/tracexec-core/src/..., crates/tracexec-exporter-*/src/...	Tests simplify initialization and assertions, avoid unnecessary clones, restrict PTY checks to bytes read, and use concise error construction and formatting.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is broadly related to a refactor, but it is too vague to convey the main change in this changeset.	Use a concise, specific title that names the primary behavior change, such as validating ptrace builder inputs and replacing panic paths with errors.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Code Review

This pull request improves error handling and robustness in the ptrace tracer backend by replacing panics and unwraps with proper error propagation using color_eyre. It also cleans up various tests across the codebase by simplifying assertions, removing redundant clones, and fixing a potential buffer issue in the PTY tests. As there are no review comments, I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[coderabbitai]

🧹 Nitpick comments (1)

crates/tracexec-core/src/pty.rs (1)

877-877: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Slice the buffer when printing.

Using the entire buffer &buf will include trailing zero-bytes that were not populated by the read. Slicing it to &buf[..bytes_read] ensures the output only contains the actual data read, preventing messy test logs.

♻️ Proposed refactor

-    eprintln!("buf: {}", String::from_utf8_lossy(&buf));
+    eprintln!("buf: {}", String::from_utf8_lossy(&buf[..bytes_read]));

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/tracexec-core/src/pty.rs` at line 877, Update the debug output near
the buffer read to pass only the populated portion of the buffer to
String::from_utf8_lossy, slicing the buffer through bytes_read instead of
printing the entire buf allocation.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@crates/tracexec-core/src/pty.rs`:
- Line 877: Update the debug output near the buffer read to pass only the
populated portion of the buffer to String::from_utf8_lossy, slicing the buffer
through bytes_read instead of printing the entire buf allocation.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: d3775f99-e24a-4eeb-983e-054ffd958ea8

📥 Commits

Reviewing files that changed from the base of the PR and between 1b0cefc and 98b27d4.

📒 Files selected for processing (10)

• crates/tracexec-backend-ptrace/src/ptrace/tracer.rs
• crates/tracexec-backend-ptrace/src/ptrace/tracer/inner.rs
• crates/tracexec-backend-ptrace/src/ptrace/tracer/test.rs
• crates/tracexec-core/src/cli.rs
• crates/tracexec-core/src/cli/config.rs
• crates/tracexec-core/src/event.rs
• crates/tracexec-core/src/event/message.rs
• crates/tracexec-core/src/pty.rs
• crates/tracexec-exporter-json/src/lib.rs
• crates/tracexec-exporter-perfetto/src/packet.rs

[codecov]

Codecov Report

❌ Patch coverage is 96.61017% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.19%. Comparing base (074c56b) to head (98b27d4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...rates/tracexec-backend-ptrace/src/ptrace/tracer.rs	88.23%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   82.16%   82.19%   +0.03%     
==========================================
  Files          84       84              
  Lines       20904    20937      +33     
==========================================
+ Hits        17175    17209      +34     
+ Misses       3729     3728       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.