test: improve policy exception validation coverage - #105
Open
karthikmanam wants to merge 1 commit into
Open
Conversation
Signed-off-by: Karthik babu Manam <karthikmanam@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR improves unit test coverage for PolicyException validation and clarifies subtest output, aligning with issue #104 by exercising previously untested validation branches without changing production behavior.
Changes:
- Renamed a duplicate
TestCELPolicyException_GetKindsubtest to avoid ambiguous test output. - Added validation test cases for a policy reference missing both
nameandkind. - Added validation coverage for multiple invalid policy references, asserting indexed field paths in returned errors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Improve the PolicyException validation test coverage by adding missing validation scenarios and making the GetKind subtest names more descriptive. This is a test-only change and does not modify production behavior.
Related issue
Fixes #104
Proposed Changes
TestCELPolicyException_GetKindsubtest for clearer test output.nameandkind.Checklist
Further Comments