Skip to content

docs: tell the Purple consent case as first and second passes - #13

Merged
labyrinth30 merged 2 commits into
mainfrom
docs/consent-case-process
Oct 5, 2026
Merged

labyrinth30 merged 2 commits into
mainfrom
docs/consent-case-process

Conversation

@labyrinth30

@labyrinth30 labyrinth30 commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

변경

  • Purple CASE 04 "내 기여와 해결" → "해결 과정" 3단계로 재구성 (PA-1868 커밋 기록 기준)
    1. 보고와 과제화
    2. 1차 (9/1): 청구 직전 차단 + 미동의 약관 동의 체크, 체크 전 재결제 버튼 비활성, 부분 동의 우회 거절
    3. 2차 (9/4): 화면에 남아 있던 Toss 약관 박스가 결제 요청 호출을 거치지 않아 동작하지 않음을 확인 → 숨기고 필수 약관 전체를 자체 박스로 표시
  • "구현하며 확인한 점"의 약관 조회 API 문장을 2차 변경과 이어지게 정리

검증

  • build 에러 0, 두 PDF 생성, e2e 32/32 통과, 1440px 스크린샷 확인

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • The repayment screen now displays all required payment terms, with previously accepted terms marked and locked.
    • Customers can review linked terms and check each outstanding term before proceeding with repayment.
  • Bug Fixes
    • Repayment is blocked until all required terms have been accepted, and acceptance is recorded only when all outstanding terms are submitted.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 48 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f7f201e2-ddc6-44a4-b0c2-894b06b4363e
📥 Commits

Reviewing files that changed from the base of the PR and between 70adb4a and c477f89.

📒 Files selected for processing (1)
  • src/content/cases/purple-consent.mdx

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 61e37718-622e-49b2-9834-d0b41f3f55e7
📥 Commits

Reviewing files that changed from the base of the PR and between 67776ec and 70adb4a.

📒 Files selected for processing (1)
  • src/content/cases/purple-consent.mdx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The case narrative now separates repayment consent controls from the custom terms box. It also clarifies that the described lookup returns all terms with each term’s consent status.

Changes

Consent case narrative

Layer / File(s) Summary
Repayment consent flow
src/content/cases/purple-consent.mdx
The narrative describes blocking charges when required terms remain unaccepted, disabling repayment until the unaccepted terms are checked, and replacing Toss’s nonfunctional terms box with a custom box. It specifies that the box displays all required terms and links to Toss’s original text. The implementation note says the lookup returns all terms with per-term consent status.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 70adb

This PR updates the consent-flow case study without changing product behavior. No concrete product-impacting issue is established, so it appears mergeable with routine checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 70adb

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in src/content/cases/purple-consent.mdx: The former combined contribution-and-solution narrative is recast as reporting and a first implementation stage. It now describes the repayment screen’s unchecked-term controls and disabled repayment button, alongside the existing charge block and rejection of partial consent submissions.
  • observed — Modified behavior in src/content/cases/purple-consent.mdx: A second stage is added to describe hiding Toss’s nonfunctional terms box on the repayment screen and replacing it with a custom box. Unlike the earlier account, which mentions displaying accepted terms as checked and disabled, the new text specifies displaying all required terms, including unchecked unaccepted terms, and linking to Toss’s original term text.
  • observed — Modified behavior in src/content/cases/purple-consent.mdx: The implementation note now states that the lookup returns all terms with per-term consent status, rather than describing the screen as showing all terms while requesting checks only for unaccepted ones.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes the main change: reorganizing the Purple consent case around its first and second implementation passes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The first attempt added the terms to the Toss widget box in the console;
QA on the development server showed that box is not sent on retry.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@labyrinth30
labyrinth30 merged commit 07050b3 into main Oct 5, 2026
3 checks passed
@labyrinth30
labyrinth30 deleted the docs/consent-case-process branch October 5, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant