Skip to content

docs: tell the GGUK async case as attempts in order - #14

Open
labyrinth30 wants to merge 2 commits into
mainfrom
docs/gguk-async-process
Open

labyrinth30 wants to merge 2 commits into
mainfrom
docs/gguk-async-process

Conversation

@labyrinth30

@labyrinth30 labyrinth30 commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

GGUK CASE 01(비동기 접수)을 "해결 과정" 단계로 다시 썼습니다.

    1. 작업 상태 테이블로 시작 (jobId, 조회 API, 만료 시각 조건)
    1. 재시도 기준이 Cloud Tasks와 DB 두 곳으로 나뉨 (리뷰 의견, 큐 설정 조회·누적 횟수 상한)
    1. 접수만 하는 구조로 전환 (상태 테이블·jobId·조회 API 제거, 401/422 → 503, Cloud Run 제한 시간 8.5분)
    1. 일부 실패한 장소만 다시 처리 (PR #74)

근거: mash-up-kr/Team-MINO-Node PR #38 커밋·리뷰 코멘트, PR #74.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated the case study to describe the transition to enqueue-only processing, including request validation, task registration, and asynchronous work on the same service.
    • Clarified retry behavior for temporary failures, the service timeout, and how successful results are retained while remaining work is retried.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bb364bd2-feab-4c15-83a0-d3830c53e0dc
📥 Commits

Reviewing files that changed from the base of the PR and between 5241a09 and 261703b.

📒 Files selected for processing (2)
  • src/content/cases/gguk-async.mdx
  • src/content/projects/gguk.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0e6b853e-8f75-4cbf-bf27-da1b9859798d
📥 Commits

Reviewing files that changed from the base of the PR and between 07050b3 and 5241a09.

📒 Files selected for processing (1)
  • src/content/cases/gguk-async.mdx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The case study now describes the transition from job-state tracking to enqueue-only processing. It documents the API response, worker authentication, retry statuses, timeout, and persistence of partial results across task redeliveries.

Changes

Async processing case study

Layer / File(s) Summary
Design transition and retry behavior
src/content/cases/gguk-async.mdx
The case study describes the initial job-state and polling design, then records its replacement with Cloud Tasks enqueueing and a worker on the same Cloud Run service. It also documents retry statuses, the timeout change, and how successful results persist before retries add missing results.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 5241a

The case study is ready to merge after normal checks; its timeout explanation does not need another sentence.

Architecture Summary

Architecture risk: 🔵 Low · up to 5241a

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in src/content/cases/gguk-async.mdx: The case-study metadata now says enqueueing is separated from analysis and names the enqueue-only PR source; the earlier decision and diagram-caption wording remains.
  • observed — Modified behavior in src/content/cases/gguk-async.mdx: The former “Responsibilities” and “Why” sections are replaced by a transition narrative that begins with the author’s integration role and the initial job-state-table design.
  • observed — Modified behavior in src/content/cases/gguk-async.mdx: The new process history describes the initial job row and jobId polling design, including worker expiry checks to prevent stale workers overwriting newer results, then explains how querying Cloud Tasks and separately tracking attempts duplicated retry state.
  • observed — Modified behavior in src/content/cases/gguk-async.mdx: The narrative records removing the status table, jobId, polling API, and separate worker service. It states that the API returns 202 Accepted only after Cloud Tasks registration, the same Cloud Run service runs the OIDC-authenticated worker, and retry outcomes depend on HTTP status: certificate-fetch failures and retryable AI-format errors now return 503 instead of 401 and 422. The Cloud Run timeout is described as reduced from 11 to 8.5 minutes, below Cloud Tasks’ 9-minute deadline.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: presenting the GGUK async case as an ordered account of the attempts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant