feat(scanner): plan _rowoffset and the DataFrame entry points - #8571
Draft
wjones127 wants to merge 1 commit into
Draft
feat(scanner): plan _rowoffset and the DataFrame entry points#8571wjones127 wants to merge 1 commit into
wjones127 wants to merge 1 commit into
Conversation
wjones127
force-pushed
the
will/logical-planner-8-tail
branch
from
August 17, 2026 16:16
055765a to
b54f475
Compare
wjones127
force-pushed
the
will/logical-planner-8-tail
branch
2 times, most recently
from
August 17, 2026 18:43
496ca48 to
2a466ab
Compare
Completes the logical scan planner's coverage of `Scanner`: a `_rowoffset` node with its row-offset map prefetched in stage 2, the `LanceContextExt` / `LanceDataFrameExt` DataFrame surface, and a planning benchmark. With this the new path can plan every query shape the imperative one can, so the two are compared directly rather than one deferring to the other. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
wjones127
force-pushed
the
will/logical-planner-8-tail
branch
from
August 17, 2026 19:08
2a466ab to
c3ba8bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last gap between the logical path and
Scanner:_rowoffset, plus the DataFrame surface the logical path makes possible.A row's offset is its position in the dataset once deletions are accounted for, so computing one needs every earlier fragment's row count and deletion vector.
AddRowOffsetExec::try_newis the only physical node constructor in the read path that does I/O, which is exactly the shape this design exists to remove: the load moves into stage 2, and a rule hands the result to the node.With that, the new path plans every query shape the imperative one can, so every scanner test compares the two directly rather than one deferring to the other.
One behavioural note on the frame surface: a row's
_created_at_version/_last_updated_at_versioncome from its position within its fragment, so only an ordered scan can produce them and the take above a search cannot. A frame with no projection of its own asks for every column the leaf advertises, so the take drops those two rather than asking the read for something it cannot return.LanceContextExt/LanceDataFrameExtfall out of the rest of the work rather than being built for it. The scanner exposes one fixed query shape — filter, search, sort, limit, project, in that order. Making that shape planable required a scan leaf that is a realTableProvider, search nodes that are real logical nodes, and a lowering stage that reads only the plan; those three together also make the fixed shape unnecessary. ADataFramecan put a search anywhere and then join, aggregate, or window the result with anything DataFusion can express.Also adds a planning benchmark, which measures the pipeline with no I/O left in it. It compares both read paths in one process, so
Scannergains a#[doc(hidden)] create_plan_logicalfor the bench to call — the last PR deletes it along with the path it was there to compare against.Stack created with GitHub Stacks CLI • Give Feedback 💬