feat(scanner): plan every read through the logical planner - #8572
Draft
wjones127 wants to merge 1 commit into
Draft
feat(scanner): plan every read through the logical planner#8572wjones127 wants to merge 1 commit into
wjones127 wants to merge 1 commit into
Conversation
wjones127
force-pushed
the
will/logical-planner-9-default
branch
2 times, most recently
from
August 17, 2026 18:17
0765793 to
5ec2684
Compare
wjones127
force-pushed
the
will/logical-planner-9-default
branch
from
August 17, 2026 18:43
5ec2684 to
66b9d90
Compare
`Scanner::create_plan` now delegates to the logical planner, and the imperative plan builder it replaces is deleted along with the `LANCE_LOGICAL_SCAN_PLANNER` switch that selected between them. The equivalence harness goes with it: it compared the two paths' rows, and there is only one path left. The oracles that state what each answer should be stay. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
wjones127
force-pushed
the
will/logical-planner-9-default
branch
from
August 17, 2026 19:08
66b9d90 to
7ed589f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the logical planner the read path.
Scanner::create_planbecomes a thin wrapper over it, the imperative plan builder it replaces is deleted, and theLANCE_LOGICAL_SCAN_PLANNERswitch that selected between them goes with it.This is deletion only — every behavioural change landed in the PRs below.
scanner.rsloses about 3,400 lines.The equivalence harness goes too. Since #8567 every test in
scanner/logical/tests/has planned its query both ways and asserted the two return the same rows; with one path left there is nothing to compare against. The oracles that state what each answer should be — recall floors, score ordering, expected row sets — stay, and now stand on their own.fts_index_fragment_bitmapbecomes test-only. Planning reads coverage fromScanPlanningContext, which already holds the segments; the function remains as the independent computation the tests check that against.Stack created with GitHub Stacks CLI • Give Feedback 💬