feat(cleanup): support cleaning specific dataset versions - #8617
Open
hfutatzhanghb wants to merge 2 commits into
Open
feat(cleanup): support cleaning specific dataset versions#8617hfutatzhanghb wants to merge 2 commits into
hfutatzhanghb wants to merge 2 commits into
Conversation
Add exact-version cleanup policy across Rust, Python, and Java. Closes lance-format#8616
github-actions
Bot
added
A-python
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The exact-version selector is applied as a narrowing predicate inside the existing cleanup engine, preserving current-version, tag, shared-file, branch-lineage, and concurrent-cleanup protections across Rust, Python, and Java.
lance-gatekeeper
Bot
added
the
K-approved
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an exact-version cleanup policy to
CleanupPolicyso users can remove only specified intermediate dataset versions.Rust and Java policy builders expose the same
versionsfilter. The filter combines with existing cleanup filters; current and tagged versions remain protected by the existing cleanup rules.Closes #8616.
Changes
CleanupPolicy::versionsandCleanupPolicyBuilder::versions.versionstocleanup_old_versionsandexplain_cleanup_old_versions.CleanupPolicy.withVersions(List<Long>)and JNI extraction.Verification
cargo check -p lance --tests,cargo check --manifest-path python/Cargo.toml, andcargo check --manifest-path java/lance-jni/Cargo.tomlpassed locally before local Cargo verification was disabled. Targeted tests were added but not run locally.