Repository navigation
ci: add yanked version of chacha crate to deny exceptions while waiting for updates - #9982
Closed
westonpace wants to merge 1 commit into
Closed
westonpace wants to merge 1 commit into
westonpace wants to merge 1 commit into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
github-actions
Bot
added
A-deps
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
| { id = "RUSTSEC-2026-0195", reason = "`quick-xml` <0.41 pulled transitively via object_store (datafusion) and reqsign-aws-v4 (opendal); upstream must upgrade first" }, | ||
| { id = "RUSTSEC-2024-0449", reason = "`serde_yaml` pulled transitively via datafusion-substrait; serde features not utilized by us" }, | ||
| ] | ||
| { crate = "chacha20@0.10.0", reason = "yanked upstream; pulled transitively via rand -> object_store, no newer version to update to yet, yanking was for UB in SSE2 which we don't really support anyways" },] |
Contributor
There was a problem hiding this comment.
chacha20 0.10.2 is already published and unyanked, and RustCrypto/stream-ciphers#580 fixes the SSE4.1 intrinsic used by the SSE2 RNG backend. The locked rand 0.10.1 accepts chacha20 ^0.10.0, so this update does not require a new rand or object_store release. Consider refreshing the root, Python, and JNI lockfiles to that version instead of suppressing the warning. This is non-blocking for this revision because the runtime dependency and its exposure are unchanged.
lance-gatekeeper
Bot
added
K-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crate yanked some versions that contained UB (illegal op / segfault prob?) in SSE2 hardware. This predates AVX2 which is what we generally use as a baseline (though I think some users use lance on older hardware).
Either way, it's a transitive dependency (via rand and object_store) and the intermediate dependencies haven't updated yet so we are stuck with it for now.