Skip to content

Recover the total length for formats that omit contentLength #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devoxin merged 1 commit into from
Aug 19, 2026
Merged

Recover the total length for formats that omit contentLength #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 39 additions & 3 deletions common/src/main/java/dev/lavalink/youtube/track/YoutubeAudioTrack.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
import dev.lavalink.youtube.clients.skeleton.Client;
import dev.lavalink.youtube.track.format.StreamFormat;
import dev.lavalink.youtube.track.format.TrackFormats;
import org.apache.http.Header;
import org.apache.http.client.methods.CloseableHttpResponse;
import org.apache.http.client.methods.HttpGet;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.slf4j.Logger;
Expand Down Expand Up @@ -135,11 +138,21 @@ private void processWithClient(LocalAudioTrackExecutor localExecutor,
boolean isLegacyFormat = query != null && query.contains("itag=18");
boolean isStream = trackInfo.isStream || (!isLegacyFormat && augmentedFormat.format.getContentLength() == CONTENT_LENGTH_UNKNOWN);

long contentLength = augmentedFormat.format.getContentLength();

// itag 18 carries no contentLength, and the stream requests ranges by query parameter, so the
// response is a plain 200 whose Content-Length describes the chunk. Without a real total the
// reader stops at the first range boundary. A zero-length ranged request returns Content-Range,
// which does carry it; if that fails we keep CONTENT_LENGTH_UNKNOWN and behave as before.
if (!trackInfo.isStream && contentLength == CONTENT_LENGTH_UNKNOWN) {
contentLength = probeContentLength(httpInterface, augmentedFormat.signedUrl);
}

try {
if (isStream) {
processStream(localExecutor, httpInterface, augmentedFormat);
} else {
processStatic(localExecutor, httpInterface, augmentedFormat, streamPosition);
processStatic(localExecutor, httpInterface, augmentedFormat, streamPosition, contentLength);
}
} catch (StreamExpiredException e) {
processWithClient(localExecutor, httpInterface, client, e.lastStreamPosition);
Expand All @@ -149,11 +162,12 @@ private void processWithClient(LocalAudioTrackExecutor localExecutor,
private void processStatic(LocalAudioTrackExecutor localExecutor,
HttpInterface httpInterface,
FormatWithUrl augmentedFormat,
long streamPosition) throws Exception {
long streamPosition,
long contentLength) throws Exception {
YoutubePersistentHttpStream stream = null;

try {
stream = new YoutubePersistentHttpStream(httpInterface, augmentedFormat.signedUrl, augmentedFormat.format.getContentLength());
stream = new YoutubePersistentHttpStream(httpInterface, augmentedFormat.signedUrl, contentLength);

if (streamPosition > 0) {
stream.seek(streamPosition);
Expand Down Expand Up @@ -188,6 +202,28 @@ private void processStream(LocalAudioTrackExecutor localExecutor,
processDelegate(new YoutubeMpegStreamAudioTrack(trackInfo, httpInterface, augmentedFormat.signedUrl), localExecutor);
}

private long probeContentLength(HttpInterface httpInterface, URI url) {
HttpGet request = new HttpGet(url);
request.setHeader("Range", "bytes=0-0");

try (CloseableHttpResponse response = httpInterface.execute(request)) {
Header contentRange = response.getFirstHeader("Content-Range");
int totalIndex = contentRange != null ? contentRange.getValue().lastIndexOf('/') : -1;

if (totalIndex != -1) {
String total = contentRange.getValue().substring(totalIndex + 1).trim();

if (!total.isEmpty() && !"*".equals(total)) {
return Long.parseLong(total);
}
}
} catch (Exception e) {
log.debug("Failed to probe content length for {}", url, e);
}

return CONTENT_LENGTH_UNKNOWN;
}

@NotNull
private FormatWithUrl loadBestFormatWithUrl(@NotNull HttpInterface httpInterface,
@NotNull Client client) throws CannotBeLoaded, Exception {
Expand Down