Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizes the ordinary
SignatureScheme::signpath. The public API, key and signature formats, and signature bytes are unchanged (the same seed and message produce the same signature).poseidon1_16()/poseidon1_24()now return&'staticinstead of cloning heap-backed round constants on every hash.IncomparableEncoding::find_encodinghook; its default keeps the original loop.MAX_TRIESlimit.u64limbs with shift/mask instead ofBigUintdivision.Pseudorandom::randomness_generatorreuses the SHAKE prefix across counters, and field reduction no longer uses genericu128division.TweakableHash::sign_chainsgroups chains of similar length into SIMD lanes, then restores the signature order.u64arithmetic instead ofu128.Benchmarks
Criterion,
Lifetime 2^18, no offset, Apple M2 Max, rustc 1.96.0. Both columns use the same harness; "before" isc08a3ba.Single core (
RAYON_NUM_THREADS=1)Signing:
Verification:
8 threads (
RAYON_NUM_THREADS=8)Verification also improves because it shares the permutation and tweak paths.
Reproduce:
RAYON_NUM_THREADS=1 cargo bench --bench benchmark -- 'Lifetime 2\^18, w = [1248], no offset' --warm-up-time 1 --measurement-time 3Testing
cargo test --release: 117 passed, 1 ignored (slow).cargo clippy --all-targets --release -- -D warningsandcargo fmt --checkare clean.BigUint.