Skip to content

feat(RingTheory): regular local ring is domain#28683

Open
Thmoas-Guan wants to merge 400 commits into
leanprover-community:masterfrom
Thmoas-Guan:Regular-Local-Ring
Open

feat(RingTheory): regular local ring is domain#28683
Thmoas-Guan wants to merge 400 commits into
leanprover-community:masterfrom
Thmoas-Guan:Regular-Local-Ring

Conversation

@Thmoas-Guan

@Thmoas-Guan Thmoas-Guan commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

In this PR, we proved for a regular local ring R,
1 : for a finite set S in the maximal Ideal of R, it can be extended to a regular system of parameters iff they are linear independent in the cotangent space iff R/span S is regular local ring of dimesion dim R - |S|

2 : is domain
3 : regular system of parameter form regular sequence.


Open in Gitpod

@github-actions

github-actions Bot commented Aug 20, 2025

Copy link
Copy Markdown

PR summary c7517fded0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.RingTheory.RegularLocalRing.Basic (new file) 2193

Declarations diff (regex)

+ FiniteRingKrullDim.ringKrullDim_eq_nat
+ Ideal.span_singleton_mul_eq_self_of_isPrime
+ IsDiscreteValuationRing.of_isRegularLocalRing_of_ringKrullDim_eq_one
+ IsLocalRing.spanFinrank_maximalIdeal_add_finrank_eq_of_surjective
+ IsLocalRing.spanFinrank_maximalIdeal_quotient
+ instance : RingHomSurjective (residue R) := ⟨residue_surjective⟩
+ instance [IsRegularLocalRing R] : IsDomain R := isDomain_of_isRegularLocalRing R
+ isDomain_of_isRegularLocalRing
+ isRegular_of_span_eq_maximalIdeal
+ quotient_isRegularLocalRing_tfae
+ quotient_span_singleton
+ spanFinrank_eq_one_iff
+ subset_iUnion_iff_mem_of_isMaximal_of_finite
+ toCotangentSpace

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit c7517fd).

  • +15 new declarations
  • −0 removed declarations
+FiniteRingKrullDim.ringKrullDim_eq_nat
+Ideal.span_singleton_mul_eq_self_of_isPrime
+Ideal.subset_iUnion_iff_mem_of_isMaximal_of_finite
+IsDiscreteValuationRing.of_isRegularLocalRing_of_ringKrullDim_eq_one
+IsLocalRing.CotangentSpace.congr_simp
+IsLocalRing.instRingHomSurjectiveResidueFieldResidue
+IsLocalRing.spanFinrank_maximalIdeal_add_finrank_eq_of_surjective
+IsLocalRing.spanFinrank_maximalIdeal_quotient
+IsLocalRing.toCotangentSpace
+Submodule.spanFinrank_eq_one_iff
+instIsDomainOfIsRegularLocalRing
+isDomain_of_isRegularLocalRing
+isRegular_of_span_eq_maximalIdeal
+quotient_isRegularLocalRing_tfae
+quotient_span_singleton

Increase in strong tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type (strong)
5666 1 backward.isDefEq.respectTransparency
No changes to weak technical debt.

Current commit c7517fded0
Reference commit 07f4b8dcd0

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Thmoas-Guan Thmoas-Guan added t-ring-theory Ring theory WIP Work in progress labels Aug 20, 2025
@Thmoas-Guan

Copy link
Copy Markdown
Collaborator Author

This PR is depending some lemma developed from Krull heights theorem.

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 20, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 21, 2025
@mathlib4-merge-conflict-bot

Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 29, 2025
@mathlib4-merge-conflict-bot

Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 19, 2025
@grunweg grunweg changed the title feat(RingTheory) : regular local ring is domain feat(RingTheory): regular local ring is domain Nov 19, 2025
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 20, 2025
@Thmoas-Guan Thmoas-Guan removed the WIP Work in progress label Dec 29, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 22, 2026
@mathlib4-merge-conflict-bot

Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 25, 2026
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 30, 2026
@mathlib4-merge-conflict-bot

Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 7, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 22, 2026
@mathlib-dependent-issues

mathlib-dependent-issues Bot commented May 22, 2026

Copy link
Copy Markdown

@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 22, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 23, 2026
@Thmoas-Guan

Copy link
Copy Markdown
Collaborator Author

I added IsLocalRing.spanFinrank_maximalIdeal_add_finrank_eq_of_surjective that would also be useful elsewhere, do we have a good place for this?

@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jun 3, 2026
@Thmoas-Guan Thmoas-Guan temporarily deployed to cache-upload-forks June 4, 2026 02:24 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants