Skip to content

feat(IsGaloisGroup): add restrictHom#38864

Open
xroblot wants to merge 28 commits into
leanprover-community:masterfrom
xroblot:restrictHom1
Open

feat(IsGaloisGroup): add restrictHom#38864
xroblot wants to merge 28 commits into
leanprover-community:masterfrom
xroblot:restrictHom1

Conversation

@xroblot

@xroblot xroblot commented May 3, 2026

Copy link
Copy Markdown
Collaborator

This PR adds the restriction map for the Galois group for domains.

Given a tower of domains A ≤ B ≤ C, G a Galois group for C/A and G' a Galois group for B/A, we define:

  • restrictHom: the restriction of the G-action on C to the G'-action on B.
  • quotientMulEquiv: the isomorphism between the quotient of G by the fixing subgroup of B and the Galois group of B/A.

Supporting lemmas include:

  • normal_of_isGalois: if G is a finite Galois group for L/K, H is a Galois group for L/E, and E/K is Galois, then H is a normal subgroup of G.
  • restrictHom_surjective: the restriction map is surjective.

Open in Gitpod

@xroblot xroblot added the WIP Work in progress label May 3, 2026
@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

PR summary 55f521fae9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ algebraMap_quotientMulEquiv_smul
+ algebraMap_restrictHom_smul
+ mulEquivCongr_mapSubgroup_fixingSubgroup
+ normal_of_isGalois
+ of_isScalarTower
+ quotientMulEquiv
+ restrictHom
+ restrictHom_surjective

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 55f521f).

  • +10 new declarations
  • −0 removed declarations
+IsGaloisGroup.algebraMap_quotientMulEquiv_smul
+IsGaloisGroup.algebraMap_restrictHom_smul
+IsGaloisGroup.mulEquivCongr.congr_simp
+IsGaloisGroup.mulEquivCongr_mapSubgroup_fixingSubgroup
+IsGaloisGroup.normal_of_isGalois
+IsGaloisGroup.of_isScalarTower
+IsGaloisGroup.quotientMulEquiv
+IsGaloisGroup.quotientMulEquiv.congr_simp
+IsGaloisGroup.restrictHom
+IsGaloisGroup.restrictHom_surjective

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 55f521fae9
Reference commit 0bee4471e4

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

xroblot added a commit to xroblot/mathlib4 that referenced this pull request May 3, 2026
xroblot added a commit to xroblot/mathlib4 that referenced this pull request May 3, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 4, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 8, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 29, 2026
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 29, 2026
@xroblot xroblot removed the WIP Work in progress label May 30, 2026
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
Comment thread Mathlib/Algebra/Group/Subgroup/Basic.lean Outdated
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
Comment thread Mathlib/FieldTheory/IntermediateField/Basic.lean Outdated
Comment thread Mathlib/FieldTheory/IntermediateField/Basic.lean Outdated
@tb65536 tb65536 added the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 1, 2026
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
@xroblot xroblot temporarily deployed to cache-upload-forks June 4, 2026 10:28 — with GitHub Actions Inactive
…y/mathlib4 into restrictHom1-clean

# Conflicts:
#	Mathlib/FieldTheory/Galois/IsGaloisGroup.lean
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
@tb65536 tb65536 added the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 19, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jun 20, 2026
Comment thread Mathlib/RingTheory/Localization/FractionRing.lean Outdated
Comment thread Mathlib/FieldTheory/IntermediateField/Basic.lean Outdated
Comment thread Mathlib/Algebra/Group/Subgroup/Basic.lean
mathlib-bors Bot pushed a commit that referenced this pull request Jun 20, 2026
…#40842)

This PR was automatically created from PR #38864 by @xroblot via a [review comment](#38864 (comment)) by @tb65536.

Co-authored-by: xroblot <46200072+xroblot@users.noreply.github.com>
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
mathlib-bors Bot pushed a commit that referenced this pull request Jun 20, 2026
…38864 (#40844)

This PR was automatically created from PR #38864 by @xroblot via a [review comment](#38864 (comment)) by @tb65536.

Co-authored-by: xroblot <46200072+xroblot@users.noreply.github.com>
Co-authored-by: Thomas Browning <tb65536@users.noreply.github.com>
xroblot added 2 commits June 20, 2026 18:52
# Conflicts:
#	Mathlib/FieldTheory/Galois/IsGaloisGroup.lean
#	Mathlib/FieldTheory/IntermediateField/Basic.lean
@xroblot

xroblot commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for the thorough review, @tb65536! I think I've incorporated everything. Should be ready for another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants