Skip to content

chore: adaptations for batteries#1863#40820

Open
grunweg wants to merge 2 commits into
masterfrom
batteries-pr-testing-1863
Open

chore: adaptations for batteries#1863#40820
grunweg wants to merge 2 commits into
masterfrom
batteries-pr-testing-1863

Conversation

@grunweg

@grunweg grunweg commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

With the defLemma being removed, we delete all corresponding nolint entries.


After leanprover-community/batteries#1863 is merged:

Edit the lakefile to point to leanprover-community/batteries:main
Run lake update batteries
Merge leanprover-community/mathlib4:master
Wait for CI and merge

Open in Gitpod

@github-actions

Copy link
Copy Markdown

PR summary e0673b65a6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit e0673b65a6
Reference commit 07f4b8dcd0

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@fgdorais fgdorais added the blocked-by-batt-PR This PR depends on a PR to Batteries label Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-batt-PR This PR depends on a PR to Batteries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants