Skip to content

[Merged by Bors] - chore(RingTheory/Polynomial/Basic): squeeze terminal simps#40833

Closed
yuanyi-350 wants to merge 1 commit into
leanprover-community:masterfrom
yuanyi-350:ringhomclass_1
Closed

[Merged by Bors] - chore(RingTheory/Polynomial/Basic): squeeze terminal simps#40833
yuanyi-350 wants to merge 1 commit into
leanprover-community:masterfrom
yuanyi-350:ringhomclass_1

Conversation

@yuanyi-350

@yuanyi-350 yuanyi-350 commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

As recommended in the style guide. Extracted from #40793.


Open in Gitpod

@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown

PR summary 3c19986341

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 3c19986).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 3c19986341
Reference commit 727fecc30e

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-ring-theory Ring theory label Jun 20, 2026
@yuanyi-350 yuanyi-350 changed the title refactor(Algebra): golf Mathlib/RingTheory/Polynomial/Basic, prepared for #40793 refactor(Algebra): golf Mathlib/RingTheory/Polynomial/Basic using simp Jun 20, 2026
@grunweg grunweg changed the title refactor(Algebra): golf Mathlib/RingTheory/Polynomial/Basic using simp refactor(RingTheory/Polynomial/Basic): squeeze terminal simps Jun 20, 2026
@grunweg grunweg changed the title refactor(RingTheory/Polynomial/Basic): squeeze terminal simps chore(RingTheory/Polynomial/Basic): squeeze terminal simps Jun 20, 2026
@grunweg

grunweg commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

!bench

@leanprover-radar

leanprover-radar commented Jun 20, 2026

Copy link
Copy Markdown

Benchmark results for 3c19986 against 727fecc are in. No significant results found. @grunweg

  • 🟥 build//instructions: +45.9G (+0.03%)

Small changes (14🟥)

  • 🟥 build/module/Aesop.Builder.Basic//instructions: +29.7M (+1.60%)
  • 🟥 build/module/Aesop.Frontend.Extension.Init//instructions: +27.7M (+1.96%)
  • 🟥 build/module/Aesop.Script.Util//instructions: +30.7M (+1.74%)
  • 🟥 build/module/Aesop.Tree.Tracing//instructions: +38.0M (+0.68%)
  • 🟥 build/module/Batteries.Data.BitVec//instructions: +22.9M (+1.68%)
  • 🟥 build/module/Batteries.Data.Char//instructions: +26.3M (+1.87%)
  • 🟥 build/module/Batteries.Data.DList//instructions: +30.0M (+2.29%)
  • 🟥 build/module/Batteries.Data.Nat.Gcd//instructions: +36.1M (+2.63%)
  • 🟥 build/module/Batteries.Data.RBMap//instructions: +26.2M (+1.85%)
  • 🟥 build/module/Batteries.Lean.Syntax//instructions: +27.4M (+2.83%)
  • 🟥 build/module/ImportGraph.Tools//instructions: +24.6M (+1.82%)
  • 🟥 build/module/Mathlib.Order.Synonym//instructions: +31.8M (+1.50%)
  • 🟥 build/module/Plausible.Tactic//instructions: +29.2M (+1.02%)
  • 🟥 build/module/Qq.Simp//instructions: +30.9M (+2.19%)

@grunweg

grunweg commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Looks like no significant change, so good to land. Note that I have reworded your PR title and description significantly --- can you please take note of this in the future? Thank you!
bors merge

mathlib-bors Bot pushed a commit that referenced this pull request Jun 20, 2026
As recommended in the style guide. Extracted from #40793.
@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Jun 20, 2026
@mathlib-bors

mathlib-bors Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(RingTheory/Polynomial/Basic): squeeze terminal simps [Merged by Bors] - chore(RingTheory/Polynomial/Basic): squeeze terminal simps Jun 20, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants