Skip to content

refactor: Add Contractions in terms of representations#1253

Open
jstoobysmith wants to merge 6 commits into
leanprover-community:masterfrom
jstoobysmith:RepContractionV2
Open

refactor: Add Contractions in terms of representations#1253
jstoobysmith wants to merge 6 commits into
leanprover-community:masterfrom
jstoobysmith:RepContractionV2

Conversation

@jstoobysmith

Copy link
Copy Markdown
Member

Add contraction of Lorentz vectors and covectors in terms of representations. This replaces #1221.

@jstoobysmith jstoobysmith added the t-relativity Relativity label Jun 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip.

Important: If a reviewer adds an awaiting-author label to your PR, once you have addressed the review comments, please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

@jstoobysmith jstoobysmith requested a review from zhikaip June 29, 2026 09:59
@morrison-daniel morrison-daniel self-assigned this Jul 1, 2026

@morrison-daniel morrison-daniel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good but I got a little cleanup. I like to avoid grind when I can because it can be a performance hit and it obfuscates the actual proof steps if used too liberally. Usually it can be replaced by less expensive tactics. Also, I think it may be helpful to write some of this in terms of more general objects like MulAction and BilinMap which would help deal with some of the linearity problems. Not necessary to add here, but something to consider for future PRs.

Comment thread Physlib/Relativity/Tensors/RealTensor/Representation/Contraction.lean Outdated
Comment thread Physlib/Relativity/Tensors/RealTensor/Representation/Contraction.lean Outdated
Comment thread Physlib/Relativity/Tensors/RealTensor/Representation/Contraction.lean Outdated
Comment thread Physlib/Relativity/Tensors/RealTensor/Representation/Contraction.lean Outdated
Comment thread Physlib/Relativity/Tensors/RealTensor/Representation/Contraction.lean Outdated
Comment thread Physlib/Relativity/Tensors/RealTensor/Representation/Contraction.lean Outdated
@morrison-daniel morrison-daniel added the awaiting-author A reviewer has asked the author a question or requested changes label Jul 1, 2026
jstoobysmith and others added 2 commits July 1, 2026 06:34
…on.lean

Co-authored-by: Daniel Morrison <39346894+morrison-daniel@users.noreply.github.com>
Co-authored-by: Daniel Morrison <39346894+morrison-daniel@users.noreply.github.com>
@jstoobysmith

Copy link
Copy Markdown
Member Author

The reason I'm using rep here rather then MulAction is because it will create a future diamond if MulAction is used. Applied your suggestions here.

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author A reviewer has asked the author a question or requested changes label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-relativity Relativity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants