-
Notifications
You must be signed in to change notification settings - Fork 134
feat: Refactor downstream use away from FieldStrengthMatrix #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NicolaBernini
wants to merge
23
commits into
leanprover-community:master
Choose a base branch
from
NicolaBernini:feat/refactor-downstream-use-away-from-fieldStrengthMatrix-27June2026
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 18 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
5a8cde2
feat: Refactor downstream use away from FieldStrengthMatrix
NicolaBernini 79339e2
style: Wrap electric field simp list
NicolaBernini b649e7f
fix: Relate field strength components to basis coefficients
NicolaBernini 1d060c3
merge: Resolve master conflicts for field strength evaluation
NicolaBernini 8aff89b
fix: Open tensor notation in electric field
NicolaBernini 0f66708
fix: Use field strength component API in electric field
NicolaBernini e517734
fix: Define field strength component by basis coefficient
NicolaBernini 062f85d
fix: Remove duplicate field strength simp lemmas
NicolaBernini 0e9415b
refactor: Use field strength evaluations directly
NicolaBernini e45a288
fix: Avoid compound indices in tensor notation
NicolaBernini c455ab3
fix: Rewrite field strength matrix conversions explicitly
NicolaBernini 16f2f47
fix: Simplify electric field smoothness proofs
NicolaBernini 198c2b2
fix: Avoid timeout in electric field smoothness proofs
NicolaBernini e1d773a
merge: Update PR 1288 with master
NicolaBernini df02354
fix: Make magnetic field matrix cases explicit
NicolaBernini a6c5971
fix: Avoid magnetic field simp loop
NicolaBernini 887e184
fix: Normalize magnetic field index cases
NicolaBernini 5267b80
Add sliding pendulum configuration space
NicolaBernini 32b08bf
fix: Close kinetic term normalization
NicolaBernini 311f607
fix: Close kinetic term residual equality
NicolaBernini 2a253d4
fix: Rewrite diagonal field strength in kinetic term
NicolaBernini 92d49d6
fix: Rewrite diagonal field strength in Hamiltonian
NicolaBernini 6cf6b15
fix: Address Hamiltonian diagonal branch
NicolaBernini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would make this
[Real.Angle](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Analysis/SpecialFunctions/Trigonometric/Angle.html#Real.Angle)rather thenReal.