Skip to content

feat: Close the smallest pendulum configuration-space sorryful definitions #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NicolaBernini wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −4
Open

feat: Close the smallest pendulum configuration-space sorryful definitions #1327

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b46ddea
feat: Close the smallest pendulum configuration-space sorryful defini…
NicolaBernini Jun 30, 2026
8640cf6
Use Real.Angle for sliding pendulum angle
NicolaBernini Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions Physlib/ClassicalMechanics/Pendulum/SlidingPendulum.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Authors: Shlok Vaibhav Singh
-/
module

public import Physlib.Meta.Linters.Sorry
public import Mathlib.Data.Real.Basic
/-!
# Sliding Pendulum
### Tag: LnL_1.5.2
Expand Down Expand Up @@ -63,9 +63,21 @@ namespace ClassicalMechanics

namespace SlidingPendulum

/-- The configuration space of the sliding pendulum system. -/
@[sorryful]
def ConfigurationSpace : Type := sorry
/-!
## A. Configuration space
-/

/--
The configuration space of the sliding pendulum system.

The generalized coordinates are the horizontal position of the support mass and the angle
that the string makes with the vertical.
-/
structure ConfigurationSpace where
/-- The horizontal position `x₁` of the support mass. -/
supportPosition : ℝ
/-- The angle `φ` that the string makes with the vertical. -/
angle : ℝ

@jstoobysmith jstoobysmith Jun 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would make this [Real.Angle](https://leanprover-community.github.io/mathlib4_docs/Mathlib/Analysis/SpecialFunctions/Trigonometric/Angle.html#Real.Angle) rather then Real.

@NicolaBernini NicolaBernini Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jstoobysmith is this solved in the last commit?


end SlidingPendulum

Expand Down
Loading