[IMP] dms: type-aware side preview pane in the file list#18
Draft
dnplkndll wants to merge 1 commit into
Draft
Conversation
Add an in-place preview pane to the file list view: clicking a row opens a side pane that renders the file by type via a scored handler registry (dms.preview_handlers) — image, PDF, audio, video, Markdown, email (.eml), source (CodeEditor), with a download fallback. The pane embeds the mail Chatter and persists its open/closed state per user in localStorage (use_stored_state). Pane visibility and the selected-row accent are wired into the existing dms list renderer.
dnplkndll
force-pushed
the
19.0-imp-dms-preview-pane
branch
from
7f94e44 to
fda6df2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a type-aware side preview pane to the file list view: clicking a row opens a pane that renders the file by type via a scored handler registry (
dms.preview_handlers) — image, PDF, audio, video, Markdown, email (.eml, parsed to a header card + sandboxed HTML body), source (CodeEditor), with a download fallback. The pane embeds the mail Chatter and persists its open/closed state per user.Depends on OCA/dms#475 (the 19.0 migration). Draft for reference until OCA#475 lands.
Non-mechanical points worth flagging
orm.readon existing fields anddoActionon existing actions (action_dms_file,wizard_dms_file_share_action).