Skip to content

Add Rspec included modules support #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShadiestGoat wants to merge 6 commits into from
Closed

Add Rspec included modules support #13

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ffb93e
Support Rspec.configure ... config.include
ShadiestGoat Jul 9, 2025
f4faace
Make tests pass
ShadiestGoat Jul 10, 2025
66d55fd
Require solargraph 56 (remote ci test)
ShadiestGoat Jul 10, 2025
7c817e7
Fix testing
ShadiestGoat Jul 13, 2025
49f22c1
Remove solargraph debug patch
ShadiestGoat Jul 16, 2025
1f8ac4b
Cleanup 1
ShadiestGoat Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,10 @@ jobs:
# - name: Run Rubocop
Copy link
Copy Markdown
Owner

@lekemula lekemula Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to bring this back again.

# run: cd solargraph-rspec && bundle exec rubocop

- name: 'Apply solargraph debug patch'
run: |-
echo 'exclude: ["vendor/**/*", "gemfiles/**/*"]' > solargraph-rspec/.solargraph.yml
cd solargraph-rspec/gemfiles/vendor/bundle/ruby/${{ matrix.ruby-version }}.0/gems/solargraph-0.56.0

awk '/Caching yardoc for/ { print "return nil unless Dir.exist?(gemspec.gem_dir)"; print; next }1' lib/solargraph/yardoc.rb > tmp.rb
mv tmp.rb lib/solargraph/yardoc.rb

- name: Cache Docs
run: |-
# Vendor files: don't do them
Copy link
Copy Markdown
Owner

@lekemula lekemula Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more context on why we don't need vendor files? My understanding is that it is because we run specs via appraisal gem, is that correct?

Copy link
Copy Markdown
Contributor Author

@ShadiestGoat ShadiestGoat Aug 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad comment on my part - we still have vendor files, just they're excluded in a different way in the sg workspace. By default, only vendor/** get excluded. The only change is **/vendor/**/*, ie. "Exclude vendor files everywhere, not just in the top dir"

echo 'exclude: ["**/vendor/**/*"]' > solargraph-rspec/.solargraph.yml
cd solargraph-rspec
bundle exec solargraph gems --rebuild

Expand Down