Reconnect FCM listener after it dies instead of hanging forever - #122
Open
P6g9YHK6 wants to merge 1 commit into
Open
Reconnect FCM listener after it dies instead of hanging forever#122P6g9YHK6 wants to merge 1 commit into
P6g9YHK6 wants to merge 1 commit into
Conversation
FcmPushClient shuts itself down after 3 sequential connection errors and never recovers. _listening was only ever set once, so nothing noticed - every locate after a crash just hung on a push that would never arrive, until the process was restarted by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FcmPushClient shuts itself down after 3 sequential connection errors
and never recovers. _listening is only ever set once, so nothing
noticed, and every locate after that just hangs until the process is
restarted by hand. Hit this in production: an SSL shutdown timeout
tripped the error threshold and every device timed out for hours.
_ensure_listening() now checks the push client's actual run_state
instead of the stale flag, locked so two callers can't both restart it
at once. _start_listener_in_background() also cleans up the old
loop/thread before starting a new one.
Touches the same function as #114, but a different concern. May need
a quick rebase depending on merge order.