Skip to content

feat(doctor): create a missing database from the finding - #1492

Open
geodro wants to merge 1 commit into
mainfrom
feat/doctor-create-missing-database
Open

feat(doctor): create a missing database from the finding#1492
geodro wants to merge 1 commit into
mainfrom
feat/doctor-create-missing-database

Conversation

@geodro

@geodro geodro commented Aug 13, 2026

Copy link
Copy Markdown
Member

A site pointing at a MySQL or Postgres schema its engine does not hold was told to go and run lerd db:create, which made it the one finding on the doctor panel ending in a command to type somewhere else. The button it did carry ran the framework's migrate command, and that could never resolve it: migrations have nowhere to run until the database exists, so pressing it failed against the very thing the finding was about.

The finding creates the database now, from the dashboard and from lerd site:doctor --fix alike. Creating a schema happens in the engine's container rather than the site's, so it runs as a host action beside installing a service the site declares, and it resolves the missing set again on the way in so it can only ever create what the check reported, stopping at the first refusal rather than reporting a half done run as done. An engine that cannot be reached still produces no finding and no work.

A database that does not exist already suppresses the framework migration check, so the migrate button returns on the re-check that follows and the two steps stay in the order they have to happen in. The SQLite sibling is untouched: an absent or empty file is exactly what migrations do create.

Closes #1491

A site pointing at a MySQL or Postgres schema its engine does not hold was told to go and run lerd db:create, the one finding on the panel ending in a command to type somewhere else, and the button it did carry ran the framework's migrate command, which has nowhere to run until the database exists.

The finding creates the database now, from the dashboard and from lerd site:doctor --fix alike. Creating a schema happens in the engine's container rather than the site's, so it runs as a host action beside installing a service the site declares, and it resolves the missing set again on the way in so it can only ever create what the check reported. A database that does not exist already suppresses the framework migration check, so the migrate button returns on the re-check that follows and the two steps stay in the order they have to happen in.
@geodro
geodro requested a review from a team as a code owner August 13, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(doctor): create a missing database from the finding instead of naming a command to type

1 participant