Show what changed after a self-managed update lands - #1493
Open
JoeJoeflyn wants to merge 1 commit into
Open
Conversation
lerd update fetches and prints the changelog before asking the user to confirm, then downloads, installs, restarts services, and returns without a word about what actually changed. doctor and status both end by pointing the user at lerd whatsnew, so the two commands that did nothing advertise the changelog while the one that just applied it stays silent. Print the same changelog that was already fetched for the confirmation prompt once the update is done, gated on feedback.Interactive() so an unattended or piped run does not dump it into a log. Package-managed installs defer to apt, dnf, or brew and never reach this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a self-managed update lands, print the changelog that was already fetched for the confirmation prompt. Gated on feedback.Interactive() so unattended runs suppress it. Package-managed installs never reach this point.
Closes #1359