test: Add minio for MTC tile storage#8790
Conversation
ezekiel
requested review from
a team,
aarongable and
jsha
and removed request for
a team and
aarongable
beautifulentropy
force-pushed
the
add-s3-storage
branch
from
8f9b64a to
f194319
Compare
ezekiel
left a comment
ezekiel
left a comment
There was a problem hiding this comment.
Suggested deleting some errant ( and also totally harmless ) empty line remnants.
| /bin/sh -c " | ||
| until mc alias set local http://boulder-minio:9000 minioadmin minioadmin >/dev/null 2>&1; do sleep 1; done; | ||
| mc mb --ignore-existing local/boulder-mtc-tiles; | ||
| exit 0; |
There was a problem hiding this comment.
Is the purpose of exit 0 to ignore errors from the mb subcommand? I would think --ignore-existing means mb will exit 0 even if the bucket exists. I think we can drop the explicit exit 0
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
LGTM with two questions that might be helped by additional documentation.
|
|
||
| bminio: | ||
| image: minio/minio:RELEASE.2025-09-07T16-13-09Z | ||
| command: server /data --console-address ":9001" |
There was a problem hiding this comment.
Based on this documentation, I don't think specifying --console-address ":9001" is necessary. If you point your browser at the API port (:9000), it auto-redirects to the randomly-selected console port, so there's no need to configure it unless you need a static port for allowlisting. But we're not allowlisting this port anywhere (docker isn't exposing it to the host, so we can't point our browsers at it anyway) so there's no point in making it static.
| - bouldernet | ||
| entrypoint: > | ||
| /bin/sh -c " | ||
| until mc alias set local http://boulder-minio:9000 minioadmin minioadmin >/dev/null 2>&1; do sleep 1; done; |
There was a problem hiding this comment.
Based on these docs, I think this is using alias set as a stand-in for ping: just doing the simplest possible operation to confirm that minio is actually up. Is that understanding correct, and if yes, can it be documented here for future readers?
4 participants
Fixes #8789