Pre-allocate res_units vector#1586
Merged
Merged
Conversation
Commit d0b99be ("Pre-allocate unit_ranges Vec with aranges-based capacity") improved DWARF parsing performance by sizing the unit_ranges vector based on the number of .debug_aranges entries. Resizing the res_units Vec is even worse in terms of performance, because the contained Unit objects are rather large (making copying more expensive). Use the same size hint to pre-allocate said vector and minimize copy operations in the process. > main/symbolize_dwarf_no_lines > time: [7.1269 ms 7.1522 ms 7.1901 ms] > change: [−30.399% −29.940% −29.484%] (p = 0.00 < 0.02) > Performance has improved. > main/symbolize_dwarf > time: [6.9546 ms 6.9988 ms 7.0619 ms] > change: [−34.973% −34.455% −33.805%] (p = 0.00 < 0.02) > Performance has improved. Reported-by: Jannik Glückert <jannik.glueckert@gmail.com> Signed-off-by: Daniel Müller <deso@posteo.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1586 +/- ##
==========================================
+ Coverage 96.21% 96.32% +0.10%
==========================================
Files 56 56
Lines 11132 11132
==========================================
+ Hits 10711 10723 +12
+ Misses 421 409 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit d0b99be ("Pre-allocate unit_ranges Vec with aranges-based capacity") improved DWARF parsing performance by sizing the unit_ranges vector based on the number of .debug_aranges entries. Resizing the res_units Vec is even worse in terms of performance, because the contained Unit objects are rather large (making copying more expensive).
Use the same size hint to pre-allocate said vector and minimize copy operations in the process.