Box up DWARF units#1589
Merged
Merged
Conversation
gimli::Unit is a sizeable type and our Units abstractions effectively stores an array of those. When many units are present (our vmlinux image has ~2200), this can lead to unnecessary high memory usage (the object may never actually be populated if it isn't involved in symbolization) and memcpy overhead when copied around. Heap allocate objects of this type in two locations to mitigate these problems and speed things up some more. Closes: libbpf#1578 Suggested-by: Jannik Glückert <jannik.glueckert@gmail.com> Signed-off-by: Daniel Müller <deso@posteo.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1589 +/- ##
==========================================
- Coverage 96.31% 96.29% -0.03%
==========================================
Files 56 56
Lines 11134 11135 +1
==========================================
- Hits 10724 10722 -2
- Misses 410 413 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d-e-s-o
force-pushed
the
topic/boxed-units
branch
from
30be091 to
304187c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gimli::Unit is a sizeable type and our Units abstractions effectively stores an array of those. When many units are present (our vmlinux image has ~2200), this can lead to unnecessary high memory usage (the object may never actually be populated if it isn't involved in symbolization) and memcpy overhead when copied around.
Heap allocate objects of this type in two locations to mitigate these problems and speed things up some more.
Closes: #1578
Suggested-by: Jannik Glückert jannik.glueckert@gmail.com