Run fonttools against TTF files to save 300KB~ - #473
Merged
Conversation
baxysquare
approved these changes
Apr 15, 2024
baxysquare
left a comment
baxysquare
left a comment
Collaborator
There was a problem hiding this comment.
I approve of this PR, as it will reduce the font sized in the repository. But I don't currently have an environment to test it in. We could really use some help from @LibretroAdmin or another top contributor to the main project.
RobLoach
approved these changes
Apr 19, 2024
RobLoach
left a comment
RobLoach
left a comment
Member
There was a problem hiding this comment.
Seems to work on Linux with XMB. I don't have any other devices to really test this on, but I assume it's okay?
RobLoach
reviewed
Apr 19, 2024
RobLoach
requested changes
May 30, 2024
RobLoach
left a comment
RobLoach
left a comment
Member
There was a problem hiding this comment.
Looks like a conflict since your last commit?
C0rn3j
force-pushed
the
optimize-images-p2
branch
from
June 3, 2024 14:05
c1c2df2 to
771e60b
Compare
Contributor
Author
|
Had to hard reset the fork, but it shouldn't conflict anymore. |
Contributor
|
We'll try this. If it causes issues we will have to revert it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conversation in #471
This needs testing before merge.