Skip to content
This repository was archived by the owner on Feb 18, 2026. It is now read-only.

Correct imported tag in GameFilter - #2416

Open
bbindreiter wants to merge 1 commit into
lichess-org:masterfrom
bbindreiter:patch-1
Open

Correct imported tag in GameFilter#2416
bbindreiter wants to merge 1 commit into
lichess-org:masterfrom
bbindreiter:patch-1

Conversation

@bbindreiter

Copy link
Copy Markdown

Hi!

As reported here #2375 and #2331 filtering for imported games is not working, which this PR attempts to fix.

Although it cannot be found in the API doc (https://lichess.org/api#tag/Games/operation/apiGamesUser), judging by the request WEB makes it must be imported instead of import

@leekaiinthesky

Copy link
Copy Markdown

Yes, please merge this pull request, if the developers have any time to do so!

@veloce Thank you for the consideration. I know this version of the mobile app isn't being worked on anymore, but it's a small edit and would fix a long-standing bug.

This resolves the following 5 open issues (including one dating back all the way to 2018!):
#911
#2331
#2375
#2428
#2521

The GameFilter enum in lila is here: https://github.com/lichess-org/lila/blob/master/modules/game/src/main/GameFilter.scala {All, Me, Rated, Win, Loss, Draw, Playing, Bookmark, Imported, Search}. So I believe @bbindreiter is correct that simply changing s/import/imported/ in his commit fixes the issue.

Thank you, and thank you to all the lichess developers. You have made such a huge contribution to the chess renaissance that we are all enjoying today!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants