walletkit: add SubmitPackage client method#280
Draft
ellemouton wants to merge 1 commit into
Draft
Conversation
ellemouton
force-pushed
the
walletkit-submitpackage
branch
from
c6ad7ac to
60fdb7e
Compare
Roasbeef
requested changes
Jun 16, 2026
|
|
||
| func (m *walletKitClient) SubmitPackage(ctx context.Context, | ||
| txns []*wire.MsgTx, | ||
| maxFeeRate *float64) (*btcjson.SubmitPackageResult, error) { |
Member
There was a problem hiding this comment.
I don't think we should leak btcjson here (notice how it was just imported with this diff). Instead we should make a higher level wrapper type like we do elsewhere for related APIs.
ellemouton
force-pushed
the
walletkit-submitpackage
branch
from
60fdb7e to
1eebf77
Compare
Add WalletKit.SubmitPackage, wrapping lnd's new WalletKit.SubmitPackage RPC. It serializes the topologically-sorted transactions, forwards the optional per-tx max fee rate (nil uses the node default), and maps the proto response back to the btcjson.SubmitPackageResult callers expect.
ellemouton
force-pushed
the
walletkit-submitpackage
branch
from
1eebf77 to
66d2a3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
WalletKitClient.SubmitPackage, wrapping lnd's newWalletKit.SubmitPackageRPC. It serializes the topologically-sorted transactions, forwards an optional
per-transaction max fee rate (
niluses the node default), and maps the protoresponse back to the
btcjson.SubmitPackageResultcallers expect.This lets a zero-fee v3/TRUC parent be relayed via its fee-paying CPFP child
(bitcoind's
submitpackage) without the caller needing a separate connectionto the chain backend.
TODO before un-drafting
go.modfrom the forkreplacesto released lnd / btcwallet versions.