Repository navigation
docs(NO-TASK): Match the secret names the product repos actually use - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README invented
RELEASE_POST_*secret names. The names actually configured onlinchpin-blocks are shorter, so the docs now match reality rather than the other way round.
RELEASE_POST_WP_USERWP_USERRELEASE_POST_WP_APP_PASSWORDWP_PASSRELEASE_POST_CF_ACCESS_CLIENT_IDCF_ACCESS_CLIENT_IDRELEASE_POST_CF_ACCESS_CLIENT_SECRETCF_ACCESS_CLIENT_SECRETThe Cloudflare pair also matches the env-var convention already used by linchpin.com's
client-sync tooling, so this is the more consistent naming regardless.
Also drops the claim that these have to be org secrets — they are repo-level on
linchpin-blocks today, and the action only reads its inputs, so it does not care either way.
linchpin-blocks#923 and
mantle#832 already use these names.
Docs only.