Skip to content

Fix feMorphology kernel size and radius rounding - #1120

Merged
LaurenzV merged 3 commits into
linebender:mainfrom
WaterWhisperer:fix-morphology-font-fallback
Oct 9, 2026
Merged

LaurenzV merged 3 commits into
linebender:mainfrom
WaterWhisperer:fix-morphology-font-fallback

Conversation

@WaterWhisperer

@WaterWhisperer WaterWhisperer commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

The morphology kernel omitted the positive-side neighbor, making erosion and dilation asymmetric. Include both ends of the kernel and round scaled radii to the nearest pixel, matching Chromium’s behavior for fractional radii.

Addresses the morphology finding in #1051.

@LaurenzV LaurenzV changed the title Fix feMorphology kernels and font fallback handling Two fixes for feMorphology kernels Oct 8, 2026
@LaurenzV

LaurenzV commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

I'll use this PR to merge the feMorphology kernel fixes, if you want the font ones please submit a new PR, thanks!

@LaurenzV
LaurenzV force-pushed the fix-morphology-font-fallback branch from ee5a001 to ed09133 Compare October 8, 2026 18:28
@LaurenzV LaurenzV changed the title Two fixes for feMorphology kernels Fix feMorphology kernel size and radius rounding Oct 8, 2026
@LaurenzV LaurenzV changed the title Fix feMorphology kernel size and radius rounding Fix feMorphology kernel size and radius rounding Oct 8, 2026
@WaterWhisperer

Copy link
Copy Markdown
Contributor Author

I'll use this PR to merge the feMorphology kernel fixes, if you want the font ones please submit a new PR, thanks!

okay, thanks!

@LaurenzV
LaurenzV merged commit fa9ff32 into linebender:main Oct 9, 2026
10 checks passed
@WaterWhisperer
WaterWhisperer deleted the fix-morphology-font-fallback branch October 9, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants