Repository navigation
Conversation
LaurenzV
commented
Oct 9, 2026
Collaborator
Author
There was a problem hiding this comment.
Chrome looks a bit different, the bottom row seems to be cut off? But the skewing itself matches now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1081. When investigating this PR, I realized that the problem is more generally that resvg handles skewed filter layers incorrectly.
What we do now is: We "absorb" the skewing/rotation factor from the filter layer, draw it purely with the scale/translation, and then skew/rotate the filtered bitmap when drawing it. This fixes a lot of test cases! All images render the same as in Chrome, except for one where there seemingly is a small issue, but probably unrelated.