-
Notifications
You must be signed in to change notification settings - Fork 295
Add EWMA and load biasing crates for failure-aware P2C balancing #4537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
5f971f6
feat(ewma): add base EWMA crate
unleashed 6cc6022
feat(ewma): add success-rate tracking extensions
unleashed 0348546
feat(classify): add Retry-After and gRPC pushback parsers
unleashed 8a7fbb2
feat(load-biaser): add load biasing crate with RTT tracking and failu…
unleashed c40a0af
test(load-biaser): add unit tests for load biasing lifecycle
unleashed 342f7d9
Update linkerd/http/classify/Cargo.toml
unleashed 11ee334
Update linkerd/load-biaser/Cargo.toml
unleashed 4f5b302
refactor(load-biaser): remove unused max parameter from attach_parsed…
unleashed b4d0693
refactor(load-biaser): encapsulate CachedRateLimitHint with construct…
unleashed 3b1d468
docs(ewma): add crate-level doc comment
unleashed 6ed442b
build(ewma): disable default tokio features
unleashed 380c8f2
build(load-biaser): declare tokio sync feature in dev-dependencies
unleashed b74b52a
refactor(classify): use GRPC_RETRY_PUSHBACK_MS constant in tests
unleashed ae6de47
fix(ewma): fix typo in test comment
unleashed 3023422
refactor(load-biaser): add #[must_use] to LoadBiaser::new
unleashed 02d9f9d
fix(load-biaser): ensure we deal with gRPC before checking gRPC status
unleashed d7f58f2
fix(load-biaser): restrict gRPC failure classification to server errors
unleashed 12adaca
test(load-biaser): add tests for extended gRPC status classification
unleashed 10b32c6
test(load-biaser): ensure repeated failures maintain penalty level
unleashed 51c7b2e
feat(ewma): expose last update timestamp
unleashed 8fe67af
test(ewma): verify last_update across construction, changes, and reads
unleashed 98aafb8
Apply suggestions from code review
unleashed d7c03b5
fix(ewma,http-classify): address feedback
unleashed d16388a
refactor(load-biaser): address feedback to use a single penalized EWM…
unleashed 2589a46
refactor(load-biaser): measure RTT to first response data frame by de…
unleashed ee9e722
refactor(load-biaser): store the failure penalty as integer milliseconds
unleashed 48e1cc3
refactor(load-biaser): name the default RTT and decay durations
unleashed 163df42
docs(load-biaser): name the gRPC status codes in the failure classifier
unleashed 761a019
docs(ewma): reword stale crate comment
unleashed 73ce450
fix(http-classify): parse grpc pushback as i32
unleashed 9e19b9a
refactor(load-biaser): consolidate mocks into MockService
unleashed a117373
refactor(load-biaser): apply ResponseFailureHint feedback
unleashed e3f47cb
refactor(load-biaser): remove unused get_ref
unleashed b19fa51
test(load-biaser): assert load values in pending test
unleashed e212159
build(load-biaser): drop orphaned test deps
unleashed c3bc7c6
docs(load-biaser): correct stale comments
unleashed 841abfa
refactor(ewma): use is_infinite instead of f64::INFINITY
unleashed cfad958
test(ewma): test add_peak when providing a lower measurement
unleashed 1d592a9
test(ewma): add() ignores old timestamp measurements
unleashed aa9e42d
feat(load-biaser): floor Retry-After effect on RTT to penalty base
unleashed d2ea6ba
test(load-biaser): measure a real success RTT
unleashed 0fa734e
test(load-biaser): count concurrent in-flight
unleashed 7ae6284
test(load-biaser): assert load values by making inject_rtt set exact RTT
unleashed fe559b5
refactor(load-biaser): record penalties when handles drop
unleashed 5771848
fix(load-biaser): floor penalty at measured RTT
unleashed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| [package] | ||
| name = "linkerd-ewma" | ||
| version = { workspace = true } | ||
| authors = { workspace = true } | ||
| license = { workspace = true } | ||
| edition = { workspace = true } | ||
| publish = { workspace = true } | ||
|
|
||
| [dependencies] | ||
| tokio = { version = "1", features = ["time"] } | ||
|
|
||
| [dev-dependencies] | ||
| tokio = { version = "1", features = ["macros", "rt", "test-util"] } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.