fix: remove password field from git get request#1028
Merged
Conversation
dennisvankekem
requested review from
Copilot
and removed request for
ferruhcihan
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Git settings API contract so GET /v2/git no longer advertises (or requires) a password field in its response schema, aligning the OpenAPI spec with the intended behavior.
Changes:
- Introduces a dedicated
GetGitSettingsOpenAPI schema (withoutpassword) and wiresGET /v2/gitto it. - Adds the new schema to OpenAPI components for reuse/reference.
- Minor import reordering in
src/otomi-stack.ts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/otomi-stack.ts | Reorders the getAuthenticatedUrl import (no functional change). |
| src/openapi/git.yaml | Removes teamAdmin ACL from AplGit and adds new GetGitSettings schema (without password). |
| src/openapi/api.yaml | Switches GET /v2/git to use GetGitSettings schema and registers it under components. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
j-zimnowoda
approved these changes
Jun 30, 2026
j-zimnowoda
pushed a commit
that referenced
this pull request
Jul 1, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.