logging: add data and metadata dump to show command#3422
Conversation
ikegami-t
force-pushed
the
show-cmd-data
branch
2 times, most recently
from
cdc0268 to
0086e73
Compare
This is for debugging the command data and metadata. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
|
If we have to introduce another log level it should be called DEBUG_VERBOSE, I think. Though my question is, do we really need it? Are the data/metadata that big? Or can we make the data/metadata output a bit smarter, e.g. skipping NULLs etc, or even parse it instead just dumping the raw buffers? |
This is to dump the command data for higher vebosity. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
|
The command dword data output by the log level debug. And the data dump function |
| LIBNVME_LOG_WARN = 1, | ||
| LIBNVME_LOG_INFO = 2, | ||
| LIBNVME_LOG_DEBUG = 3, | ||
| LIBNVME_LOG_DEBUG_VERBOSE = 4, |
There was a problem hiding this comment.
You need also to update libnvme/libnvme/nvme.i accordingly.
|
Okay, then let's have the DEBUG_VERBOSE, but it's the last log level! (famous last words) |
2 participants
This is for debugging the command data and metadata.