fix: test concurrent cache-miss

[ulemons]

Summary

improve lock for redis

Type of change

• Bug fix
• New feature
• Refactor / cleanup
• Performance improvement
• Chore / dependency update
• Documentation

[Copilot]

Pull request overview

This PR introduces a Redis-based “single-flight” helper and integrates it into the members advanced query cache-miss/refresh paths to prevent concurrent requests from stampeding the database on cold keys.

Changes:

• Added withSingleFlight helper in @crowd/redis to coordinate concurrent callers behind a lock while polling cache.
• Updated queryMembersAdvanced to single-flight cache misses and align background refresh locking with the same primitive.
• Added a shared cap constant to prevent the activityCount top‑N optimization from silently truncating oversized pages.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
services/libs/redis/src/singleFlight.ts	New single-flight helper built on existing Redis mutex primitives.
services/libs/redis/src/index.ts	Exports the new single-flight helper from the redis lib barrel.
services/libs/data-access-layer/src/members/queryCache.ts	Removes the previous refresh-lock helpers from MemberQueryCache.
services/libs/data-access-layer/src/members/queryBuilder.ts	Adds a shared top‑N cap constant and guards optimized path against truncation.
services/libs/data-access-layer/src/members/base.ts	Uses single-flight on members advanced cache misses and switches background refresh locking to acquireLock/releaseLock.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

[Copilot]

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.

[Copilot]

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 8 comments.

[Copilot]

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

[cursor]

PR Summary

Medium Risk
Changes locking and concurrency on a high-traffic members list path; mis-tuned TTL/wait could still allow duplicate queries, and the activityCount gate changes which SQL path large paginated/export requests use.

Overview
Prevents cache-miss stampedes on members advanced queries by routing synchronous DB work through a new Redis withSingleFlight helper: one request holds the lock and runs the query; others poll the cache until it fills or the wait window ends (90s lock TTL aligned with wait timeout).

Background refreshes now use the same lock key and acquireLock/releaseLock primitives as the miss path (non-blocking try), replacing MemberQueryCache’s separate refresh-lock helpers so hit-triggered refresh and miss-triggered compute cannot duplicate the same heavy query.

Query behavior fixes: the main list query no longer forces the member-orgs join when orgs are loaded separately; the activityCount top-N path falls back to the full query when limit/offset (with oversampling) would exceed the shared 50k cap, avoiding silent truncation on large exports.

^{Reviewed by Cursor Bugbot for commit 60042d7. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Reviewed by Cursor Bugbot for commit 60042d7. Configure here.}

[cursor]

Compute locks survive invalidation

Medium Severity

Single-flight and background refresh now take Redis mutexes on unprefixed cache key strings via acquireLock, but MemberQueryCache invalidation still only deletes locks under the members-refresh-lock cache prefix. After cache invalidation, leftover compute locks can block repopulation for up to the 90s TTL.

Additional Locations (2)

• services/libs/data-access-layer/src/members/base.ts#L668-L671
• services/libs/data-access-layer/src/members/queryCache.ts#L118-L140

 

^{Reviewed by Cursor Bugbot for commit 60042d7. Configure here.}