Updated log messages and user messages to reflect trade compliance #5108
Updated log messages and user messages to reflect trade compliance #5108mkdolan wants to merge 1 commit into
Conversation
…view points. Signed-off-by: Mike Dolan <mikedolan@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughCompliance-blocking errors and logs in corporate signature requests and callbacks now use trade-compliance review wording instead of sanctioned-company wording. ChangesTrade compliance wording
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
There was a problem hiding this comment.
Pull request overview
Updates corporate-signing messages to clarify that flagged entities require trade compliance review rather than implying sanctions.
Changes:
- Revises user-facing corporate signature errors.
- Updates callback and screening log messages.
| if sanctioned { | ||
| if input.CompanySfid != nil { | ||
| err = fmt.Errorf("company %s is sanctioned", *input.CompanySfid) | ||
| err = fmt.Errorf("company %s requires further review for trade compliance", *input.CompanySfid) |
|
@mlehotskylf we can also update UI messages in case of blocked org. You can check contributor and corporate console and update message(s) there as well, or let me know the exact wording and I can update them. |
|
@lukaszgryglicki please identify all messages across all EasyCLA UI we show to the user in case the org is blocked and let it review by @mkdolan. |
|
OK will do tomorrow 1st thing. Added to my |
Updated log and end user messaging to reflect trade compliance reviews are required. A compliance check that results in a flag does not mean the entity is sanctioned; it indicates that further review is required.