feat(platform): add X/Twitter Ads client (OAuth 1.0a)#19

Merged

dealako merged 30 commits into

mainfrom

feat/LFXV2-2640-twitter-platform-client

Jul 13, 2026

Commits on Jul 11, 2026

feat(platform): add X/Twitter Ads client (OAuth 1.0a)

mrautela365
and
claude
committed
fix(review): address Copilot findings on X/Twitter client (PR #19)
mrautela365
committed
fix(review): pagination-cap error + fragment-safe UTM URL (PR #19)
mrautela365
committed
fix(review): harden Twitter client per PR #19 review
mrautela365
committed
fix(review): enforce 255-char names, guard funding id, cover query signing (PR #19 round 2)
mrautela365
committed
fix(review): count EventName in runes, fix unreachable 429-exhausted return (PR #19 round 3)
mrautela365
committed
fix(review): drop unsupported campaign flight dates, fix budget/status accuracy (PR #19 round 4)
mrautela365
committed
fix(review): canonical tlf slug, document rate-limit scope, don't swallow promoted-tweet failure (PR #19 round 5)
mrautela365
committed
fix(review): guard nil http client, make write pacing injectable (PR #19 round 6)
mrautela365
committed
fix(review): scope line-item lookup by campaign_ids; correct OKF doc (PR #19 round 7)
mrautela365
committed
fix(review): RFC-correct OAuth param sort, error on id-less match, tighten test handlers (PR #19 round 8)

mrautela365
and
claude
committed
docs(test): fix stale write-delay comment (PR #19)
mrautela365
committed
fix(review): trim TweetID before use (PR #19)
mrautela365
committed
fix(review): trim+use account/funding ids, validate TweetID format up front (PR #19 round 9)
mrautela365
committed
fix(review): tighten TweetID to a valid snowflake shape (PR #19)
mrautela365
committed
fix(review): reject out-of-int64-range TweetID up front (PR #19)
mrautela365
committed
fix(review): duplicate-promoted-tweet is a warning not success; validate account id charset; test overflow via CreateCampaign (PR #19 round 10)

mrautela365
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(platform): add X/Twitter Ads client (OAuth 1.0a)#19

feat(platform): add X/Twitter Ads client (OAuth 1.0a)#19
dealako merged 30 commits into
mainfrom
feat/LFXV2-2640-twitter-platform-client

Commits on Jul 11, 2026

feat(platform): add X/Twitter Ads client (OAuth 1.0a)

fix(review): address Copilot findings on X/Twitter client (PR #19)

fix(review): pagination-cap error + fragment-safe UTM URL (PR #19)

fix(review): harden Twitter client per PR #19 review

fix(review): enforce 255-char names, guard funding id, cover query signing (PR #19 round 2)

fix(review): count EventName in runes, fix unreachable 429-exhausted return (PR #19 round 3)

fix(review): drop unsupported campaign flight dates, fix budget/status accuracy (PR #19 round 4)

fix(review): canonical tlf slug, document rate-limit scope, don't swallow promoted-tweet failure (PR #19 round 5)

fix(review): guard nil http client, make write pacing injectable (PR #19 round 6)

fix(review): scope line-item lookup by campaign_ids; correct OKF doc (PR #19 round 7)

fix(review): RFC-correct OAuth param sort, error on id-less match, tighten test handlers (PR #19 round 8)

docs(test): fix stale write-delay comment (PR #19)

fix(review): trim TweetID before use (PR #19)

fix(review): trim+use account/funding ids, validate TweetID format up front (PR #19 round 9)

fix(review): tighten TweetID to a valid snowflake shape (PR #19)

fix(review): reject out-of-int64-range TweetID up front (PR #19)

fix(review): duplicate-promoted-tweet is a warning not success; validate account id charset; test overflow via CreateCampaign (PR #19 round 10)

Commits on Jul 13, 2026

fix(review): route verifyAccount through doRequest, cap computed backoff, validate RegistrationURL, fix doc (PR #19 round 11)

fix(review): honor X-Account-Rate-Limit-Reset, reject empty project, rename dup test (PR #19 round 12)

test(review): make guard tests reach their branches; fix misplaced doc (PR #19)

fix(review): surface response-body read errors in doRequest (PR #19)

fix(review): request max page size in find-or-create lookup (PR #19)

fix(review): use X Ads q= name filter in find-or-create (PR #19)

fix(review): guard Retry-After overflow; return partial result on downstream failure (PR #19)

docs(okf): add recommended tags and timestamp frontmatter (PR #19)

fix(review): RFC 5849 URI normalization in OAuth base string (PR #19)

test+fix(review): cover URI normalization; warn on name-reuse config drift (PR #19)

fix(review): preserve escaped path and IPv6 brackets in OAuth base string (PR #19)

fix(review): accurate partial-result wording on reuse; race-safe call counters (PR #19)

fix(review): sign all multi-valued query params; trim base-URL trailing slash (PR #19)