Skip to content

idas: wire NLSstg LSolveFn in IDASetNonlinearSolverSensStg to prevent NULL crash #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OfficialDelta wants to merge 2 commits into
base: main
Choose a base branch
from
Open

idas: wire NLSstg LSolveFn in IDASetNonlinearSolverSensStg to prevent NULL crash #907

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b9841b
idas: wire NLSstg LSolveFn in IDASetNonlinearSolverSensStg to prevent…
Apr 11, 2026
2b369a6
Merge branch 'main' into fix/idas-staggered-fsa-null-lsolvefn
gardner48 Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/idas/idas_nls_stg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,34 @@ int IDASetNonlinearSolverSensStg(void* ida_mem, SUNNonlinearSolver NLS)
NV_VEC_SW(IDA_mem->ewtStg, is) = IDA_mem->ida_ewtS[is];
}

/* Wire LSolveFn/LSetupFn immediately if the linear solver is already set.
* Without this, replacing NLSstg after IDACalcIC (which sets
* ida_SetupDone=TRUE) leaves LSolveFn=NULL on the new NLS because
* idaNlsInitSensStg only runs from IDAInitialSetup, which is skipped
* when ida_SetupDone is already TRUE. Any subsequent Newton solve on
* NLSstg then crashes with a NULL function pointer dereference. */
if (IDA_mem->ida_lsolve)
{
retval = SUNNonlinSolSetLSolveFn(IDA_mem->NLSstg, idaNlsLSolveSensStg);
if (retval != IDA_SUCCESS)
{
IDAProcessError(IDA_mem, IDA_ILL_INPUT, __LINE__, __func__, __FILE__,
"Setting linear solver solve function failed");
return (IDA_ILL_INPUT);
}
}

if (IDA_mem->ida_lsetup)
{
retval = SUNNonlinSolSetLSetupFn(IDA_mem->NLSstg, idaNlsLSetupSensStg);
if (retval != IDA_SUCCESS)
{
IDAProcessError(IDA_mem, IDA_ILL_INPUT, __LINE__, __func__, __FILE__,
"Setting linear solver setup function failed");
return (IDA_ILL_INPUT);
}
}

return (IDA_SUCCESS);
}

Expand Down
Loading